Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1113953002: Revert of base: Remove use of MessageLoopProxy (Closed)

Created:
5 years, 7 months ago by stevenjb
Modified:
5 years, 7 months ago
Reviewers:
danakj, Sami
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, tfarina, gavinp+memory_chromium.org, grt+watch_chromium.org, oshima+watch_chromium.org, wfh+watch_chromium.org, tracing+reviews_chromium.org, estade+watch_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of base: Remove use of MessageLoopProxy (patchset #6 id:100001 of https://codereview.chromium.org/1100773004/) Reason for revert: This CL caused this failure: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/2126 I would strongly recommend doing this in smaller pieces since it combines mechanical changes with more subtle ones (base/prefs, base/task). Original issue's description: > base: Remove use of MessageLoopProxy > > Replace usage of MessageLoopProxy under base/ with SingleThreadTaskRunner > and ThreadTaskRunnerHandle (excluding the implementation of MessageLoopProxy > itself which will removed later). > > This patch was mostly autogenerated with > https://codereview.chromium.org/1010073002. > > Depends on https://codereview.chromium.org/1086733002/. > > BUG=465354 > TBR=nkostylev@chromium.org,pkasting@chromium.org,pauljensen@chromium.org > > Committed: https://crrev.com/62aa5ca413e15738ebebbb9acd271138ec808739 > Cr-Commit-Position: refs/heads/master@{#327512} TBR=danakj@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=465354 Committed: https://crrev.com/7669182866d8605d98a5141f7b82be3b516799ca Cr-Commit-Position: refs/heads/master@{#327573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+505 lines, -445 lines) Patch
M base/android/application_status_listener_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M base/async_socket_io_handler_unittest.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M base/bind_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M base/cancelable_callback_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M base/chromeos/memory_pressure_monitor_chromeos.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M base/critical_closure.h View 1 chunk +1 line, -1 line 0 comments Download
M base/deferred_sequenced_task_runner_unittest.cc View 4 chunks +19 lines, -13 lines 0 comments Download
M base/files/file_path_watcher.h View 3 chunks +6 lines, -7 lines 0 comments Download
M base/files/file_path_watcher_fsevents.cc View 8 chunks +8 lines, -9 lines 0 comments Download
M base/files/file_path_watcher_kqueue.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/files/file_path_watcher_kqueue.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M base/files/file_path_watcher_linux.cc View 6 chunks +16 lines, -14 lines 0 comments Download
M base/files/file_path_watcher_unittest.cc View 8 chunks +17 lines, -17 lines 0 comments Download
M base/files/file_path_watcher_win.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M base/files/file_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_proxy_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/files/file_util_proxy_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/files/important_file_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer_unittest.cc View 6 chunks +15 lines, -14 lines 0 comments Download
M base/memory/ref_counted_delete_on_message_loop.h View 2 chunks +1 line, -2 lines 0 comments Download
M base/memory/weak_ptr_unittest.cc View 5 chunks +25 lines, -20 lines 0 comments Download
M base/observer_list_threadsafe.h View 3 chunks +7 lines, -6 lines 0 comments Download
M base/observer_list_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M base/posix/unix_domain_socket_linux_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M base/prefs/json_pref_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 18 chunks +60 lines, -33 lines 0 comments Download
M base/prefs/pref_member.h View 4 chunks +7 lines, -4 lines 0 comments Download
M base/prefs/pref_member.cc View 4 chunks +13 lines, -10 lines 0 comments Download
M base/prefs/pref_member_unittest.cc View 8 chunks +12 lines, -16 lines 0 comments Download
M base/prefs/pref_service.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M base/sequence_checker_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M base/single_thread_task_runner.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/synchronization/cancellation_flag_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M base/synchronization/condition_variable_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M base/synchronization/waitable_event_watcher_posix.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/task/cancelable_task_tracker.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M base/task/cancelable_task_tracker_unittest.cc View 7 chunks +27 lines, -18 lines 0 comments Download
M base/task_runner_util_unittest.cc View 5 chunks +13 lines, -7 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 9 chunks +29 lines, -18 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 4 chunks +12 lines, -9 lines 0 comments Download
M base/test/sequenced_worker_pool_owner.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/test/task_runner_test_template.h View 2 chunks +1 line, -3 lines 0 comments Download
M base/test/thread_test_helper.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/test/thread_test_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/threading/post_task_and_reply_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/threading/post_task_and_reply_impl.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M base/threading/sequenced_worker_pool.h View 3 chunks +2 lines, -4 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/thread.cc View 2 chunks +1 line, -2 lines 0 comments Download
M base/threading/thread_perftest.cc View 4 chunks +15 lines, -11 lines 0 comments Download
M base/threading/thread_unittest.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M base/threading/worker_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_event_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_event_impl.h View 3 chunks +3 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_impl.cc View 9 chunks +16 lines, -18 lines 0 comments Download
M base/trace_event/trace_event_memory.h View 3 chunks +8 lines, -7 lines 0 comments Download
M base/trace_event/trace_event_memory.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M base/trace_event/trace_event_memory_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M base/trace_event/trace_event_system_stats_monitor_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/trace_event/trace_event_unittest.cc View 10 chunks +22 lines, -23 lines 0 comments Download
M base/win/object_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/auth/online_attempt.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chromeos/login/auth/online_attempt_host.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/webdata/common/web_data_service_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_entry_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stevenjb
Created Revert of base: Remove use of MessageLoopProxy
5 years, 7 months ago (2015-04-29 21:17:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113953002/1
5 years, 7 months ago (2015-04-29 21:17:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 21:43:19 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:44:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7669182866d8605d98a5141f7b82be3b516799ca
Cr-Commit-Position: refs/heads/master@{#327573}

Powered by Google App Engine
This is Rietveld 408576698