| Index: base/trace_event/trace_event_impl.cc
|
| diff --git a/base/trace_event/trace_event_impl.cc b/base/trace_event/trace_event_impl.cc
|
| index f1c87ddac9bb87aab2778a45a318402bbfa10d8b..cbeeeabb0cbc833611d22d85c23781e562fe3f5e 100644
|
| --- a/base/trace_event/trace_event_impl.cc
|
| +++ b/base/trace_event/trace_event_impl.cc
|
| @@ -14,8 +14,8 @@
|
| #include "base/format_macros.h"
|
| #include "base/json/string_escape.h"
|
| #include "base/lazy_instance.h"
|
| -#include "base/location.h"
|
| #include "base/memory/singleton.h"
|
| +#include "base/message_loop/message_loop.h"
|
| #include "base/process/process_metrics.h"
|
| #include "base/stl_util.h"
|
| #include "base/strings/string_number_conversions.h"
|
| @@ -28,7 +28,6 @@
|
| #include "base/synchronization/waitable_event.h"
|
| #include "base/sys_info.h"
|
| #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
|
| -#include "base/thread_task_runner_handle.h"
|
| #include "base/threading/platform_thread.h"
|
| #include "base/threading/thread_id_name_manager.h"
|
| #include "base/threading/worker_pool.h"
|
| @@ -1407,7 +1406,7 @@
|
| AutoLock lock(lock_);
|
|
|
| // Can't enable tracing when Flush() is in progress.
|
| - DCHECK(!flush_task_runner_);
|
| + DCHECK(!flush_message_loop_proxy_.get());
|
|
|
| InternalTraceOptions new_options =
|
| GetInternalOptionsFromTraceOptions(options);
|
| @@ -1681,9 +1680,9 @@
|
| }
|
|
|
| // Flush() works as the following:
|
| -// 1. Flush() is called in thread A whose task runner is saved in
|
| -// flush_task_runner_;
|
| -// 2. If thread_message_loops_ is not empty, thread A posts task to each message
|
| +// 1. Flush() is called in threadA whose message loop is saved in
|
| +// flush_message_loop_proxy_;
|
| +// 2. If thread_message_loops_ is not empty, threadA posts task to each message
|
| // loop to flush the thread local buffers; otherwise finish the flush;
|
| // 3. FlushCurrentThread() deletes the thread local event buffer:
|
| // - The last batch of events of the thread are flushed into the main buffer;
|
| @@ -1711,11 +1710,9 @@
|
| thread_message_loop_task_runners;
|
| {
|
| AutoLock lock(lock_);
|
| - DCHECK(!flush_task_runner_);
|
| - flush_task_runner_ = ThreadTaskRunnerHandle::IsSet()
|
| - ? ThreadTaskRunnerHandle::Get()
|
| - : nullptr;
|
| - DCHECK_IMPLIES(thread_message_loops_.size(), flush_task_runner_);
|
| + DCHECK(!flush_message_loop_proxy_.get());
|
| + flush_message_loop_proxy_ = MessageLoopProxy::current();
|
| + DCHECK(!thread_message_loops_.size() || flush_message_loop_proxy_.get());
|
| flush_output_callback_ = cb;
|
|
|
| if (thread_shared_chunk_) {
|
| @@ -1738,7 +1735,7 @@
|
| FROM_HERE,
|
| Bind(&TraceLog::FlushCurrentThread, Unretained(this), generation));
|
| }
|
| - flush_task_runner_->PostDelayedTask(
|
| + flush_message_loop_proxy_->PostDelayedTask(
|
| FROM_HERE,
|
| Bind(&TraceLog::OnFlushTimeout, Unretained(this), generation),
|
| TimeDelta::FromMilliseconds(kThreadFlushTimeoutMs));
|
| @@ -1792,7 +1789,7 @@
|
| UseNextTraceBuffer();
|
| thread_message_loops_.clear();
|
|
|
| - flush_task_runner_ = NULL;
|
| + flush_message_loop_proxy_ = NULL;
|
| flush_output_callback = flush_output_callback_;
|
| flush_output_callback_.Reset();
|
| }
|
| @@ -1815,7 +1812,7 @@
|
| void TraceLog::FlushCurrentThread(int generation) {
|
| {
|
| AutoLock lock(lock_);
|
| - if (!CheckGeneration(generation) || !flush_task_runner_) {
|
| + if (!CheckGeneration(generation) || !flush_message_loop_proxy_.get()) {
|
| // This is late. The corresponding flush has finished.
|
| return;
|
| }
|
| @@ -1825,18 +1822,19 @@
|
| delete thread_local_event_buffer_.Get();
|
|
|
| AutoLock lock(lock_);
|
| - if (!CheckGeneration(generation) || !flush_task_runner_ ||
|
| + if (!CheckGeneration(generation) || !flush_message_loop_proxy_.get() ||
|
| thread_message_loops_.size())
|
| return;
|
|
|
| - flush_task_runner_->PostTask(
|
| - FROM_HERE, Bind(&TraceLog::FinishFlush, Unretained(this), generation));
|
| + flush_message_loop_proxy_->PostTask(
|
| + FROM_HERE,
|
| + Bind(&TraceLog::FinishFlush, Unretained(this), generation));
|
| }
|
|
|
| void TraceLog::OnFlushTimeout(int generation) {
|
| {
|
| AutoLock lock(lock_);
|
| - if (!CheckGeneration(generation) || !flush_task_runner_) {
|
| + if (!CheckGeneration(generation) || !flush_message_loop_proxy_.get()) {
|
| // Flush has finished before timeout.
|
| return;
|
| }
|
|
|