Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1113783002: Use Local instead of Handle in src/content/* (Closed)

Created:
5 years, 7 months ago by deepak.s
Modified:
5 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, aboxhall+watch_chromium.org, ben+mojo_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, jam, je_julie(Not used), jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nektar+watch_chromium.org, piman+watch_chromium.org, plundblad+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yuzo+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Local instead of Handle in src/content/* Handle is just an alias of Local BUG=424445 Committed: https://crrev.com/750d68f445f70f32932962397a4dee96888934bf Cr-Commit-Position: refs/heads/master@{#327674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -514 lines) Patch
M content/child/v8_value_converter_impl.h View 2 chunks +15 lines, -15 lines 0 comments Download
M content/child/v8_value_converter_impl.cc View 17 chunks +29 lines, -29 lines 0 comments Download
M content/child/v8_value_converter_impl_unittest.cc View 30 chunks +61 lines, -61 lines 0 comments Download
M content/child/webmessageportchannel_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/child/v8_value_converter.h View 6 chunks +9 lines, -9 lines 0 comments Download
M content/public/renderer/render_frame_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/render_view_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/chrome_object_extensions_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/chrome_object_extensions_utils.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/renderer/dom_automation_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 17 chunks +23 lines, -23 lines 0 comments Download
M content/renderer/java/gin_java_bridge_object.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/java/gin_java_function_invocation_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/java/gin_java_function_invocation_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/memory_benchmarking_extension.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/host_var_tracker.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/host_var_tracker.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/pepper/host_var_tracker_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/message_channel.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/message_channel.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/pepper/pepper_try_catch.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/pepper/pepper_try_catch.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/plugin_object.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/plugin_object.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/ppb_var_deprecated_impl.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M content/renderer/pepper/resource_converter.h View 3 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/pepper/resource_converter.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/pepper/v8_var_converter.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/pepper/v8_var_converter.cc View 20 chunks +31 lines, -31 lines 0 comments Download
M content/renderer/pepper/v8_var_converter_unittest.cc View 10 chunks +22 lines, -22 lines 0 comments Download
M content/renderer/pepper/v8object_var.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/v8object_var.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/skia_benchmarking_extension.cc View 13 chunks +15 lines, -15 lines 0 comments Download
M content/renderer/stats_collection_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/web_ui_extension.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/web_ui_mojo.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/web_ui_mojo.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/web_ui_mojo_context_state.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/web_ui_mojo_context_state.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/web_ui_runner.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/web_ui_runner.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/renderer/binding_helpers.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/gc_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/accessibility_controller.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/accessibility_controller.cc View 10 chunks +25 lines, -25 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 4 chunks +9 lines, -9 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 23 chunks +37 lines, -37 lines 0 comments Download
M content/shell/renderer/test_runner/text_input_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.h View 6 chunks +18 lines, -18 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 14 chunks +34 lines, -34 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
deepak.s
PTAL? Thanks!
5 years, 7 months ago (2015-04-29 13:37:48 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-29 15:27:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113783002/1
5 years, 7 months ago (2015-04-30 01:16:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/60110)
5 years, 7 months ago (2015-04-30 01:24:27 UTC) #7
deepak.s
5 years, 7 months ago (2015-04-30 01:32:49 UTC) #9
deepak.s
Should I add TBR in the commit message and commit?
5 years, 7 months ago (2015-04-30 03:16:11 UTC) #10
haraken
On 2015/04/30 03:16:11, deepak.s wrote: > Should I add TBR in the commit message and ...
5 years, 7 months ago (2015-04-30 03:23:05 UTC) #11
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-30 07:25:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113783002/1
5 years, 7 months ago (2015-04-30 07:26:33 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 07:32:49 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 07:34:26 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/750d68f445f70f32932962397a4dee96888934bf
Cr-Commit-Position: refs/heads/master@{#327674}

Powered by Google App Engine
This is Rietveld 408576698