Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: Source/modules/webaudio/DelayNode.cpp

Issue 111373003: Migrate bindings constructors to the new ExceptionState model. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/DelayNode.cpp
diff --git a/Source/modules/webaudio/DelayNode.cpp b/Source/modules/webaudio/DelayNode.cpp
index 611ae867153095a057f5bcbd698788417c2da5a6..7a8817ee82e2d07530da46c9d099f1a9018e4666 100644
--- a/Source/modules/webaudio/DelayNode.cpp
+++ b/Source/modules/webaudio/DelayNode.cpp
@@ -43,11 +43,9 @@ DelayNode::DelayNode(AudioContext* context, float sampleRate, double maxDelayTim
if (maxDelayTime <= 0 || maxDelayTime >= maximumAllowedDelayTime) {
exceptionState.throwDOMException(
NotSupportedError,
jochen (gone - plz use gerrit) 2013/12/10 11:41:19 can you clarify why this is not actually a ctor?
Mike West 2013/12/10 11:51:27 If it's called via `new DelayNode()`, it's a const
- ExceptionMessages::failedToConstruct(
- "DelayNode",
- "max delay time (" + String::number(maxDelayTime)
- + ") must be between 0 and " + String::number(maximumAllowedDelayTime)
- + ", exclusive."));
+ "max delay time (" + String::number(maxDelayTime)
+ + ") must be between 0 and " + String::number(maximumAllowedDelayTime)
+ + ", exclusive.");
return;
}
m_processor = adoptPtr(new DelayProcessor(context, sampleRate, 1, maxDelayTime));

Powered by Google App Engine
This is Rietveld 408576698