Autofill: Make the iOS nameForAutofill() match Blink.

Autofill: Make the iOS nameForAutofill() match Blink.

This fixes the FormStructureBrowserTest for
01_autocomplete_attribute_invalid.html

BUG=427614
Committed: https://crrev.com/cfcda55b59a217534dae2ee0351ee3020a908498
Cr-Commit-Position: refs/heads/master@{#329216}

[Lei Zhang, 2015-04-30 23:16:31]

thestig@chromium.org changed reviewers:
+ droger@chromium.org, estade@chromium.org

[Lei Zhang, 2015-04-30 23:16:32]

This code was upstreamed in https://codereview.chromium.org/788253002. I can't
figure the old copy in the internal repo, so I have no idea why we were looking
at the placeholder and autocomplete attributes.

[droger, 2015-05-01 09:14:00]

droger@chromium.org changed reviewers:
+ jyquinn@chromium.org, stuartmorgan@chromium.org

[droger, 2015-05-01 09:14:01]

Adding stuartmorgan and jyquinn who may know this code. I don't know who can
review this.

[stuartmorgan, 2015-05-01 13:43:33]

On 2015/04/30 23:16:32, Lei Zhang wrote:
> I have no idea why we were looking
> at the placeholder and autocomplete attributes.

Did the native code this was based on used to have these lines? If so, that
would be why. If not, I can dig into history.

[Lei Zhang, 2015-05-01 20:03:30]

On 2015/05/01 13:43:33, stuartmorgan wrote:
> On 2015/04/30 23:16:32, Lei Zhang wrote:
> > I have no idea why we were looking
> > at the placeholder and autocomplete attributes.
> 
> Did the native code this was based on used to have these lines? If so, that
> would be why. If not, I can dig into history.

I looked through the Blink/WK history and don't see the C++ code using
placeholder/autocomplete. A few snapshots of the code through time:

https://src.chromium.org/viewvc/blink/trunk/Source/web/WebFormControlElement....
https://src.chromium.org/viewvc/blink/trunk/Source/web/WebFormControlElement....
https://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFormControlE...
https://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFormControlE...

[stuartmorgan, 2015-05-01 20:33:19]

I dug into it:
  crbug.com/325206 is the source of one half.
  crbug.com/328852 is the source of the other.
Those link to the commits and reviews

[Lei Zhang, 2015-05-09 01:46:53]

I looked at those bugs and their associated CLs. Notes below:

https://codereview.chromium.org/1113263002/diff/1/ios/web/web_state/js/resour...
File ios/web/web_state/js/resources/common.js (left):

https://codereview.chromium.org/1113263002/diff/1/ios/web/web_state/js/resour...
ios/web/web_state/js/resources/common.js:431: trimmedName =
element.getAttribute('autocomplete');
https://chromereviews.googleplex.com/19497013 which added this is wrong IMO due
to the incorrect changes it made to the autocomplete_attribute_invalid test
expectations.

__gCrWeb.autofill.webFormControlElementToFormField() also calls
element.getAttribute('autocomplete') and all the autocomplete_attribute
heuristics tests passes at ToT. Perhaps it was broken before, so Jim felt this
was the correct solution, but it's simply not needed now.

https://codereview.chromium.org/1113263002/diff/1/ios/web/web_state/js/resour...
ios/web/web_state/js/resources/common.js:435: trimmedName =
element.getAttribute('placeholder');
For placeholder, AKA crbug.com/325206, upstream eventually implemented the same
feature in https://codereview.chromium.org/675883002, which then got ported to
autofill_controller.js in https://chromereviews.googleplex.com/112877013. The
20_checkout_staples.com.html test case would fail if we didn't consider the
placeholder attribute.

[stuartmorgan, 2015-05-10 21:43:52]

LGTM then!

[Lei Zhang, 2015-05-11 18:58:23]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-05-11 19:00:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1113263002/1

[commit-bot: I haz the power, 2015-05-11 19:07:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-11 19:09:35]

Patchset 1 (id:??) landed as
https://crrev.com/cfcda55b59a217534dae2ee0351ee3020a908498
Cr-Commit-Position: refs/heads/master@{#329216}