Upstream injected JavaScript for the iOS web layer

Upstream injected JavaScript for the iOS web layer

Committed: https://crrev.com/de686181d97b8a6bc7f5d843e045d9550212109f
Cr-Commit-Position: refs/heads/master@{#307890}

[droger, 2014-12-10 18:07:14]

droger@chromium.org changed reviewers:
+ sdefresne@chromium.org

[droger, 2014-12-10 18:07:14]

https://codereview.chromium.org/788253002/diff/1/ios/web/js_compile.gypi
File ios/web/js_compile.gypi (right):

https://codereview.chromium.org/788253002/diff/1/ios/web/js_compile.gypi#newc...
ios/web/js_compile.gypi:8: #TODO(ios): Enable javascript compilation.
I did not upstream that part, because it requires third party code.

[sdefresne, 2014-12-10 18:29:11]

https://codereview.chromium.org/788253002/diff/1/ios/web/ios_web.gyp
File ios/web/ios_web.gyp (right):

https://codereview.chromium.org/788253002/diff/1/ios/web/ios_web.gyp#newcode67
ios/web/ios_web.gyp:67: ['enable_wkwebview==1', {
This variable "enable_wkwebview" is not defined in build/common.gypi upstream.
You'll have to also upstream the definition.

https://codereview.chromium.org/788253002/diff/1/ios/web/js_compile.gypi
File ios/web/js_compile.gypi (right):

https://codereview.chromium.org/788253002/diff/1/ios/web/js_compile.gypi#newc...
ios/web/js_compile.gypi:8: #TODO(ios): Enable javascript compilation.
On 2014/12/10 at 18:07:14, droger wrote:
> I did not upstream that part, because it requires third party code.

Can you create a bug to add this dependency to third_party upstream and link it
there.
BTW, could you please put a space after the # sign?

[droger, 2014-12-11 09:36:35]

https://codereview.chromium.org/788253002/diff/1/ios/web/ios_web.gyp
File ios/web/ios_web.gyp (right):

https://codereview.chromium.org/788253002/diff/1/ios/web/ios_web.gyp#newcode67
ios/web/ios_web.gyp:67: ['enable_wkwebview==1', {
On 2014/12/10 18:29:11, sdefresne wrote:
> This variable "enable_wkwebview" is not defined in build/common.gypi upstream.
> You'll have to also upstream the definition.

I am not sure this should go in common.gypi.
Removed.

https://codereview.chromium.org/788253002/diff/1/ios/web/js_compile.gypi
File ios/web/js_compile.gypi (right):

https://codereview.chromium.org/788253002/diff/1/ios/web/js_compile.gypi#newc...
ios/web/js_compile.gypi:8: #TODO(ios): Enable javascript compilation.
On 2014/12/10 18:29:11, sdefresne wrote:
> On 2014/12/10 at 18:07:14, droger wrote:
> > I did not upstream that part, because it requires third party code.
> 
> Can you create a bug to add this dependency to third_party upstream and link
it
> there.
> BTW, could you please put a space after the # sign?

Do we really want to create individual bugs for upstreaming? Or can I use a
generic "upstream iOS code" bug?

[sdefresne, 2014-12-11 10:42:43]

On 2014/12/11 at 09:36:35, droger wrote:
> https://codereview.chromium.org/788253002/diff/1/ios/web/ios_web.gyp
> File ios/web/ios_web.gyp (right):
> 
> https://codereview.chromium.org/788253002/diff/1/ios/web/ios_web.gyp#newcode67
> ios/web/ios_web.gyp:67: ['enable_wkwebview==1', {
> On 2014/12/10 18:29:11, sdefresne wrote:
> > This variable "enable_wkwebview" is not defined in build/common.gypi
upstream.
> > You'll have to also upstream the definition.
> 
> I am not sure this should go in common.gypi.
> Removed.
> 
> https://codereview.chromium.org/788253002/diff/1/ios/web/js_compile.gypi
> File ios/web/js_compile.gypi (right):
> 
>
https://codereview.chromium.org/788253002/diff/1/ios/web/js_compile.gypi#newc...
> ios/web/js_compile.gypi:8: #TODO(ios): Enable javascript compilation.
> On 2014/12/10 18:29:11, sdefresne wrote:
> > On 2014/12/10 at 18:07:14, droger wrote:
> > > I did not upstream that part, because it requires third party code.
> > 
> > Can you create a bug to add this dependency to third_party upstream and link
it
> > there.
> > BTW, could you please put a space after the # sign?
> 
> Do we really want to create individual bugs for upstreaming? Or can I use a
generic "upstream iOS code" bug?

lgtm

You can use http://crbug.com/429756

[droger, 2014-12-11 12:18:50]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-12-11 12:19:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788253002/70001

[commit-bot: I haz the power, 2014-12-11 12:56:20]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2014-12-11 12:56:58]

Patchset 5 (id:??) landed as
https://crrev.com/de686181d97b8a6bc7f5d843e045d9550212109f
Cr-Commit-Position: refs/heads/master@{#307890}