Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 675883002: Autofill: Consider placeholder text when inferring an input's label. (Closed)

Created:
6 years, 1 month ago by Evan Stade
Modified:
6 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@staples
Project:
chromium
Visibility:
Public.

Description

Autofill: Consider placeholder text when inferring an input's label. This fixes Staples checkout. BUG=426571 Committed: https://crrev.com/86db401f0fba9d6f708fbfb72e38d97e3fe042e1 Cr-Commit-Position: refs/heads/master@{#301189}

Patch Set 1 #

Patch Set 2 : fewer curlies #

Patch Set 3 : rebase expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M chrome/test/data/autofill/heuristics/output/20_checkout_staples.com.out View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
somewhat surprised this doesn't affect the rest of the test suite at all
6 years, 1 month ago (2014-10-23 22:19:37 UTC) #2
Ilya Sherman
Hmm, I wonder whether we should treat the placeholder text as a label, or include ...
6 years, 1 month ago (2014-10-23 22:27:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675883002/40001
6 years, 1 month ago (2014-10-24 18:37:19 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-24 20:33:34 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 20:34:10 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/86db401f0fba9d6f708fbfb72e38d97e3fe042e1
Cr-Commit-Position: refs/heads/master@{#301189}

Powered by Google App Engine
This is Rietveld 408576698