Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Issue 1112833004: Add HTMLResourcePreloader preconnect unit tests (Closed)

Created:
5 years, 7 months ago by Yoav Weiss
Modified:
5 years, 3 months ago
Reviewers:
Mike West
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, kenneth.christiansen, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add HTMLResourcePreloader preconnect unit tests This CL adds unit tests for HTMLResourcePreloader that make sure that preconnect requests behave as expected. BUG= Committed: https://crrev.com/7e0b3a1a509f055cdfc06a0ff0d61790aeaf1bce git-svn-id: svn://svn.chromium.org/blink/trunk@199564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix broken tests #

Patch Set 4 : Fixed crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -10 lines) Patch
M Source/core/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.h View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.cpp View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
A Source/core/html/parser/HTMLResourcePreloaderTest.cpp View 1 2 3 1 chunk +96 lines, -0 lines 0 comments Download
M Source/core/html/parser/ResourcePreloader.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/parser/ResourcePreloader.cpp View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (2 generated)
Yoav Weiss
Hey Mike, This is a followup to https://codereview.chromium.org/1245223008/ Cheers :) Yoav
5 years, 4 months ago (2015-07-27 11:52:58 UTC) #2
Mike West
The LinkLoaderTest.DNSPrefetch and LinkLoaderTest.Preconnect failures look relevant.
5 years, 4 months ago (2015-07-27 12:37:04 UTC) #3
Yoav Weiss
On 2015/07/27 12:37:04, Mike West wrote: > The LinkLoaderTest.DNSPrefetch and LinkLoaderTest.Preconnect failures look > relevant. ...
5 years, 4 months ago (2015-07-27 12:38:41 UTC) #4
Yoav Weiss
On 2015/07/27 12:38:41, Yoav Weiss wrote: > On 2015/07/27 12:37:04, Mike West wrote: > > ...
5 years, 4 months ago (2015-07-27 14:41:11 UTC) #5
Yoav Weiss
On 2015/07/27 14:41:11, Yoav Weiss wrote: > On 2015/07/27 12:38:41, Yoav Weiss wrote: > > ...
5 years, 4 months ago (2015-07-27 15:52:49 UTC) #6
Mike West
LGTM, thanks for fixing up the test.
5 years, 4 months ago (2015-07-28 04:32:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112833004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1112833004/60001
5 years, 4 months ago (2015-07-28 06:15:59 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199564
5 years, 4 months ago (2015-07-28 06:18:29 UTC) #10
philipj_slow
This is the cause of a linker error I'm seeing, with GYP_DEFINES="component=shared_library linux_use_debug_fission=0 linux_use_bundled_binutils=0 clang=0 ...
5 years, 4 months ago (2015-07-28 14:25:06 UTC) #11
Yoav Weiss
On 2015/07/28 14:25:06, philipj wrote: > This is the cause of a linker error I'm ...
5 years, 4 months ago (2015-07-28 14:37:39 UTC) #12
Mostyn Bramley-Moore
On 2015/07/28 14:37:39, Yoav Weiss wrote: > On 2015/07/28 14:25:06, philipj wrote: > > This ...
5 years, 4 months ago (2015-07-29 08:28:00 UTC) #13
Mostyn Bramley-Moore
On 2015/07/29 08:28:00, Mostyn Bramley-Moore wrote: > I also see this error when building webkit_unit_tests, ...
5 years, 4 months ago (2015-07-29 08:41:32 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:50:17 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7e0b3a1a509f055cdfc06a0ff0d61790aeaf1bce

Powered by Google App Engine
This is Rietveld 408576698