Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: Source/core/html/parser/HTMLResourcePreloaderTest.cpp

Issue 1112833004: Add HTMLResourcePreloader preconnect unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed crash Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/parser/HTMLResourcePreloader.cpp ('k') | Source/core/html/parser/ResourcePreloader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/parser/HTMLResourcePreloaderTest.cpp
diff --git a/Source/core/html/parser/HTMLResourcePreloaderTest.cpp b/Source/core/html/parser/HTMLResourcePreloaderTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..792205295313ed2fb4854adf66fa81827e681533
--- /dev/null
+++ b/Source/core/html/parser/HTMLResourcePreloaderTest.cpp
@@ -0,0 +1,96 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "core/html/parser/HTMLResourcePreloader.h"
+
+#include "core/html/parser/PreloadRequest.h"
+#include "core/testing/DummyPageHolder.h"
+#include <gtest/gtest.h>
+
+namespace blink {
+
+struct PreconnectTestCase {
+ const char* baseURL;
+ const char* url;
+ bool isCORS;
+ bool isHTTPS;
+};
+
+class PreloaderNetworkHintsMock : public NetworkHintsInterface {
+public:
+ PreloaderNetworkHintsMock()
+ : m_didPreconnect(false)
+ {
+ }
+
+ void dnsPrefetchHost(const String& host) const { }
+ void preconnectHost(const KURL& host, const CrossOriginAttributeValue crossOrigin) const override
+ {
+ m_didPreconnect = true;
+ m_isHTTPS = host.protocolIs("https");
+ m_isCrossOrigin = (crossOrigin == CrossOriginAttributeAnonymous);
+ }
+
+ bool didPreconnect() { return m_didPreconnect; }
+ bool isHTTPS() { return m_isHTTPS; }
+ bool isCrossOrigin() { return m_isCrossOrigin; }
+
+private:
+ mutable bool m_didPreconnect;
+ mutable bool m_isHTTPS;
+ mutable bool m_isCrossOrigin;
+};
+
+class HTMLResourcePreloaderTest : public testing::Test {
+protected:
+ HTMLResourcePreloaderTest()
+ : m_dummyPageHolder(DummyPageHolder::create())
+ {
+ }
+
+ void test(PreconnectTestCase testCase)
+ {
+ // TODO(yoav): Need a mock loader here to verify things are happenning beyond preconnect.
+ PreloaderNetworkHintsMock networkHints;
+ OwnPtr<PreloadRequest> preloadRequest = PreloadRequest::create(String(),
+ TextPosition(),
+ testCase.url,
+ KURL(ParsedURLStringTag(), testCase.baseURL),
+ Resource::Image,
+ ReferrerPolicy(),
+ FetchRequest::ResourceWidth(),
+ ClientHintsPreferences(),
+ PreloadRequest::RequestTypePreconnect);
+ if (testCase.isCORS)
+ preloadRequest->setCrossOriginEnabled(DoNotAllowStoredCredentials);
+ OwnPtrWillBeRawPtr<HTMLResourcePreloader> preloader = HTMLResourcePreloader::create(m_dummyPageHolder->document());
+ preloader->preload(preloadRequest.release(), networkHints);
+ ASSERT_TRUE(networkHints.didPreconnect());
+ ASSERT_EQ(testCase.isCORS, networkHints.isCrossOrigin());
+ ASSERT_EQ(testCase.isHTTPS, networkHints.isHTTPS());
+ }
+
+private:
+ OwnPtr<DummyPageHolder> m_dummyPageHolder;
+};
+
+TEST_F(HTMLResourcePreloaderTest, testPreconnect)
+{
+ PreconnectTestCase testCases[] = {
+ { "http://example.test", "http://example.com", false, false },
+ { "http://example.test", "http://example.com", true, false },
+ { "http://example.test", "https://example.com", true, true },
+ { "http://example.test", "https://example.com", false, true },
+ { "http://example.test", "//example.com", false, false },
+ { "http://example.test", "//example.com", true, false },
+ { "https://example.test", "//example.com", false, true },
+ { "https://example.test", "//example.com", true, true },
+ };
+
+ for (const auto& testCase : testCases)
+ test(testCase);
+}
+
+} // namespace blink
« no previous file with comments | « Source/core/html/parser/HTMLResourcePreloader.cpp ('k') | Source/core/html/parser/ResourcePreloader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698