Add HTMLResourcePreloader preconnect unit tests

Add HTMLResourcePreloader preconnect unit tests

This CL adds unit tests for HTMLResourcePreloader that make sure that preconnect requests behave as expected.

BUG=

Committed: https://crrev.com/7e0b3a1a509f055cdfc06a0ff0d61790aeaf1bce
git-svn-id: svn://svn.chromium.org/blink/trunk@199564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Yoav Weiss, 2015-07-27 11:50:23]

yoav@yoav.ws changed reviewers:
+ mkwst@chromium.org

[Yoav Weiss, 2015-07-27 11:52:58]

Hey Mike,

This is a followup to https://codereview.chromium.org/1245223008/

Cheers :)
Yoav

[Mike West, 2015-07-27 12:37:04]

The LinkLoaderTest.DNSPrefetch and LinkLoaderTest.Preconnect failures look
relevant.

[Yoav Weiss, 2015-07-27 12:38:41]

On 2015/07/27 12:37:04, Mike West wrote:
> The LinkLoaderTest.DNSPrefetch and LinkLoaderTest.Preconnect failures look
> relevant.

Indeed. Looking

[Yoav Weiss, 2015-07-27 14:41:11]

On 2015/07/27 12:38:41, Yoav Weiss wrote:
> On 2015/07/27 12:37:04, Mike West wrote:
> > The LinkLoaderTest.DNSPrefetch and LinkLoaderTest.Preconnect failures look
> > relevant.
> 
> Indeed. Looking

Mock class name collision. Should be all good now.

[Yoav Weiss, 2015-07-27 15:52:49]

On 2015/07/27 14:41:11, Yoav Weiss wrote:
> On 2015/07/27 12:38:41, Yoav Weiss wrote:
> > On 2015/07/27 12:37:04, Mike West wrote:
> > > The LinkLoaderTest.DNSPrefetch and LinkLoaderTest.Preconnect failures look
> > > relevant.
> > 
> > Indeed. Looking
> 
> Mock class name collision. Should be all good now.

still failing... looking

[Mike West, 2015-07-28 04:32:40]

LGTM, thanks for fixing up the test.

[Yoav Weiss, 2015-07-28 06:15:51]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2015-07-28 06:15:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1112833004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1112833004/60001

[commit-bot: I haz the power, 2015-07-28 06:18:29]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199564

[philipj_slow, 2015-07-28 14:25:06]

This is the cause of a linker error I'm seeing, with
GYP_DEFINES="component=shared_library linux_use_debug_fission=0
linux_use_bundled_binutils=0 clang=0 disable_nacl=1 werror=":

../../third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h:39:
error: undefined reference to 'vtable for blink::HTMLResourcePreloader'
/home/philip/src/chromium/src/third_party/binutils/Linux_x64/Release/bin/ld.gold:
the vtable symbol may be undefined because the class is missing its key function
collect2: error: ld returned 1 exit status

Any idea what's going on here? I tried adding a destructor and fiddling with
CORE_EXPORT but that did not work.

[Yoav Weiss, 2015-07-28 14:37:39]

On 2015/07/28 14:25:06, philipj wrote:
> This is the cause of a linker error I'm seeing, with
> GYP_DEFINES="component=shared_library linux_use_debug_fission=0
> linux_use_bundled_binutils=0 clang=0 disable_nacl=1 werror=":
> 
> ../../third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h:39:
> error: undefined reference to 'vtable for blink::HTMLResourcePreloader'
>
/home/philip/src/chromium/src/third_party/binutils/Linux_x64/Release/bin/ld.gold:
> the vtable symbol may be undefined because the class is missing its key
function
> collect2: error: ld returned 1 exit status
> 
> Any idea what's going on here? I tried adding a destructor and fiddling with
> CORE_EXPORT but that did not work.

Haven't seen that error at all :/
I'm using `export GYP_DEFINES="clang=1 component=shared_library werror=
fastbuild=1 dcheck_always_on=1"`

[Mostyn Bramley-Moore, 2015-07-29 08:28:00]

On 2015/07/28 14:37:39, Yoav Weiss wrote:
> On 2015/07/28 14:25:06, philipj wrote:
> > This is the cause of a linker error I'm seeing, with
> > GYP_DEFINES="component=shared_library linux_use_debug_fission=0
> > linux_use_bundled_binutils=0 clang=0 disable_nacl=1 werror=":
> > 
> > ../../third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h:39:
> > error: undefined reference to 'vtable for blink::HTMLResourcePreloader'
> >
>
/home/philip/src/chromium/src/third_party/binutils/Linux_x64/Release/bin/ld.gold:
> > the vtable symbol may be undefined because the class is missing its key
> function
> > collect2: error: ld returned 1 exit status
> > 
> > Any idea what's going on here? I tried adding a destructor and fiddling with
> > CORE_EXPORT but that did not work.
> 
> Haven't seen that error at all :/
> I'm using `export GYP_DEFINES="clang=1 component=shared_library werror=
> fastbuild=1 dcheck_always_on=1"`

I also see this error when building webkit_unit_tests, during the
libblink_web.so link step.  The vtable for blink::HTMLResourcePreloader is in
libwebcore_shared.so, and that library is listed in the lib/libblink_web.so.rsp
file when building libblink_web.so, so I'm not sure why it can't find the symbol
:/

[Mostyn Bramley-Moore, 2015-07-29 08:41:32]

On 2015/07/29 08:28:00, Mostyn Bramley-Moore wrote:
> I also see this error when building webkit_unit_tests, during the
> libblink_web.so link step.  The vtable for blink::HTMLResourcePreloader is in
> libwebcore_shared.so, and that library is listed in the
lib/libblink_web.so.rsp
> file when building libblink_web.so, so I'm not sure why it can't find the
symbol
> :/

Ahh, the vtable is a local symbol in libwebcore_shared.so, I assume because
HTMLResourcePreloader has some virtual methods that weren't exported.  Proposed
fix:
https://codereview.chromium.org/1266533002/

[commit-bot: I haz the power, 2015-09-23 11:50:17]

Patchset 4 (id:??) landed as
https://crrev.com/7e0b3a1a509f055cdfc06a0ff0d61790aeaf1bce