Oilpan: Remove OffHeapCollectionTrait

Oilpan: Remove OffHeapCollectionTrait

Now that Oilpan supports HeapVector that contains objects with vtables, we no longer need OffHeapCollectionTrait.

- Replaces Deque<PendingScript> with HeapDeque<PendingScript>.
- Replaces Vector<IDLDictionary> with HeapVector<IDLDictionary>.
- Removes OffHeapCollectionTrait and related tests.

BUG=475801
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194793

[haraken, 2015-05-01 02:03:48]

haraken@chromium.org changed reviewers:
+ bashi@chromium.org, oilpan-reviews@chromium.org, yutak@chromium.org

[haraken, 2015-05-01 02:04:08]

PTAL

bashi@: bindings/
yutak@: heap/

[Yuta Kitamura, 2015-05-01 03:52:49]

heap/ core/ modules/ LGTM.

[bashi, 2015-05-01 04:31:23]

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/core/v8/V8B...
File Source/bindings/core/v8/V8Binding.h (right):

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/core/v8/V8B...
Source/bindings/core/v8/V8Binding.h:791: template <class T>
nit: class -> typename

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/core/v8/V8B...
Source/bindings/core/v8/V8Binding.h:794: v8::Local<v8::Value>
v8Value(v8::Local<v8::Value>::New(isolate, value));
Help me understand: why do you create temporary v8Value? "v8::Local<v8::Object>
object = v8::Local<v8::Object>::Cast(value)" isn't enough?

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/scripts/v8_...
File Source/bindings/scripts/v8_types.py (right):

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/scripts/v8_...
Source/bindings/scripts/v8_types.py:313: if idl_type.is_garbage_collected or
idl_type.is_dictionary:
Shouldn't we also add is_union_type?

(It sounds a bit strange because dictionaries are not garbage collected object,
but it's not refcounted object too, so it would be fine)

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/scripts/v8_...
Source/bindings/scripts/v8_types.py:593: elif
native_array_element_type.is_dictionary:
Same for native_array_element_type.is_union_type ?

[haraken, 2015-05-01 05:34:12]

Thanks for review!

bashi-san@: PTAL.

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/core/v8/V8B...
File Source/bindings/core/v8/V8Binding.h (right):

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/core/v8/V8B...
Source/bindings/core/v8/V8Binding.h:791: template <class T>
On 2015/05/01 04:31:23, bashi1(slow) wrote:
> nit: class -> typename

Done.

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/core/v8/V8B...
Source/bindings/core/v8/V8Binding.h:794: v8::Local<v8::Value>
v8Value(v8::Local<v8::Value>::New(isolate, value));
On 2015/05/01 04:31:23, bashi1(slow) wrote:
> Help me understand: why do you create temporary v8Value?
"v8::Local<v8::Object>
> object = v8::Local<v8::Object>::Cast(value)" isn't enough?

Done. (Actually I just copied the code from the above.)

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/scripts/v8_...
File Source/bindings/scripts/v8_types.py (right):

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/scripts/v8_...
Source/bindings/scripts/v8_types.py:313: if idl_type.is_garbage_collected or
idl_type.is_dictionary:
On 2015/05/01 04:31:23, bashi1(slow) wrote:
> Shouldn't we also add is_union_type?
> 
> (It sounds a bit strange because dictionaries are not garbage collected
object,
> but it's not refcounted object too, so it would be fine)

Yeah, that's confusing. "GarbageCollectedObject" here means objects that need
tracing (not objects that derive GarbageCollected). So it makes sense to make
dictionaries and union types "GarbageCollectedObject".

https://codereview.chromium.org/1112363003/diff/1/Source/bindings/scripts/v8_...
Source/bindings/scripts/v8_types.py:313: if idl_type.is_garbage_collected or
idl_type.is_dictionary:
On 2015/05/01 04:31:23, bashi1(slow) wrote:
> Shouldn't we also add is_union_type?
> 
> (It sounds a bit strange because dictionaries are not garbage collected
object,
> but it's not refcounted object too, so it would be fine)

Regarding union types, I noticed that it's (already) buggy in a couple of ways.
Let me address the issue in a separate CL.

[haraken, 2015-05-01 06:16:32]

Sorry, now the build is fixed.

[bashi, 2015-05-01 06:20:55]

bindings/ LGTM

[haraken, 2015-05-01 06:21:31]

The CQ bit was checked by haraken@chromium.org

[haraken, 2015-05-01 06:21:32]

The patchset sent to the CQ was uploaded after l-g-t-m from yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/1112363003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-05-01 06:22:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1112363003/40001

[commit-bot: I haz the power, 2015-05-01 07:37:49]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194793