Oilpan: Remove OffHeapCollectionTrait

Source/bindings/core/v8/V8Binding.h

 /*
 * Copyright (C) 2009 Google Inc. All rights reserved.
 * Copyright (C) 2012 Ericsson AB. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
@@ skipping 770 matching lines @@
             exceptionState.rethrowV8Exception(block.Exception());
             return Vector<T>();
         }
         result.uncheckedAppend(TraitsType::nativeValue(isolate, element, exceptionState));
         if (exceptionState.hadException())
             return Vector<T>();
     }
     return result;
 }
 
+template <class T>

[bashi, 2015/05/01 04:31:23]

nit: class -> typename

[haraken, 2015/05/01 05:34:11]

Done.

+HeapVector<T> toImplHeapArray(v8::Local<v8::Value> value, int argumentIndex, v8::Isolate* isolate, ExceptionState& exceptionState)
+{
+    v8::Local<v8::Value> v8Value(v8::Local<v8::Value>::New(isolate, value));

[bashi, 2015/05/01 04:31:23]

Help me understand: why do you create temporary v8Value? "v8::Local<v8::Object>
object = v8::Local<v8::Object>::Cast(value)" isn't enough?

[haraken, 2015/05/01 05:34:11]

Done. (Actually I just copied the code from the above.)

+    uint32_t length = 0;
+    if (value->IsArray()) {
+        length = v8::Local<v8::Array>::Cast(v8Value)->Length();
+    } else if (!toV8Sequence(value, length, isolate, exceptionState)) {
+        if (!exceptionState.hadException())
+            exceptionState.throwTypeError(ExceptionMessages::notAnArrayTypeArgumentOrValue(argumentIndex));
+        return HeapVector<T>();
+    }
+
+    if (length > WTF::DefaultAllocatorQuantizer::kMaxUnquantizedAllocation / sizeof(T)) {
+        exceptionState.throwTypeError("Array length exceeds supported limit.");
+        return HeapVector<T>();
+    }
+
+    HeapVector<T> result;
+    result.reserveInitialCapacity(length);
+    typedef NativeValueTraits<T> TraitsType;
+    v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(v8Value);
+    v8::TryCatch block;
+    for (uint32_t i = 0; i < length; ++i) {
+        v8::Local<v8::Value> element;
+        if (!v8Call(object->Get(isolate->GetCurrentContext(), i), element, block)) {
+            exceptionState.rethrowV8Exception(block.Exception());
+            return HeapVector<T>();
+        }
+        result.uncheckedAppend(TraitsType::nativeValue(isolate, element, exceptionState));
+        if (exceptionState.hadException())
+            return HeapVector<T>();
+    }
+    return result;
+}
+
 template <typename T>
 Vector<T> toImplArray(const Vector<ScriptValue>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
 {
     Vector<T> result;
     result.reserveInitialCapacity(value.size());
     for (unsigned i = 0; i < value.size(); ++i) {
         result.uncheckedAppend(NativeValueTraits<T>::nativeValue(isolate, value[i].v8Value(), exceptionState));
         if (exceptionState.hadException())
             return Vector<T>();
     }
@@ skipping 260 matching lines @@
 PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(v8::Isolate*, ExecutionContext*, v8::Local<v8::Function>);
 
 // Callback functions used by generated code.
 CORE_EXPORT void v8ConstructorAttributeGetter(v8::Local<v8::Name> propertyName, const v8::PropertyCallbackInfo<v8::Value>&);
 
 typedef void (*InstallTemplateFunction)(v8::Local<v8::FunctionTemplate>, v8::Isolate*);
 
 } // namespace blink
 
 #endif // V8Binding_h