Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 1112363003: Oilpan: Remove OffHeapCollectionTrait (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/tests/results/core/TestDictionary.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_types.py
diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py
index 512e324aa64bc40c5447600dc3f822a650787a49..5e8a45aad46f67fd4d5df1ced2e418bff463a361 100644
--- a/Source/bindings/scripts/v8_types.py
+++ b/Source/bindings/scripts/v8_types.py
@@ -310,7 +310,7 @@ IdlType.set_will_be_garbage_collected_types = classmethod(
def gc_type(idl_type):
- if idl_type.is_garbage_collected:
+ if idl_type.is_garbage_collected or idl_type.is_dictionary:
return 'GarbageCollectedObject'
if idl_type.is_will_be_garbage_collected:
return 'WillBeGarbageCollectedObject'
@@ -590,6 +590,10 @@ def v8_value_to_cpp_value_array_or_sequence(native_array_element_type, v8_value,
this_cpp_type = None
ref_ptr_type = cpp_ptr_type('RefPtr', 'Member', native_array_element_type.gc_type)
expression_format = '(to{ref_ptr_type}NativeArray<{native_array_element_type}, V8{native_array_element_type}>({v8_value}, {index}, {isolate}, exceptionState))'
+ elif native_array_element_type.is_dictionary:
+ ref_ptr_type = None
+ this_cpp_type = native_array_element_type.cpp_type
+ expression_format = 'toImplHeapArray<{cpp_type}>({v8_value}, {index}, {isolate}, exceptionState)'
else:
ref_ptr_type = None
this_cpp_type = native_array_element_type.cpp_type
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/tests/results/core/TestDictionary.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698