Fix a crash related to obsolete factory syntax.

Fix a crash related to obsolete factory syntax.

[ahe, 2012-10-12 15:33:22]

Fixes http://dartbug.com/5017.

[karlklose, 2012-10-15 07:59:25]

LGTM.

https://codereview.chromium.org/11117022/diff/1/dart/lib/compiler/implementat...
File dart/lib/compiler/implementation/tree/unparser.dart (right):

https://codereview.chromium.org/11117022/diff/1/dart/lib/compiler/implementat...
dart/lib/compiler/implementation/tree/unparser.dart:274: if (node.argumentsNode
!= null) {
You could add this condition to the if above.

[Lasse Reichstein Nielsen, 2012-10-15 08:34:37]

lgtm

https://codereview.chromium.org/11117022/diff/1/dart/lib/compiler/implementat...
File dart/lib/compiler/implementation/scanner/class_element_parser.dart (right):

https://codereview.chromium.org/11117022/diff/1/dart/lib/compiler/implementat...
dart/lib/compiler/implementation/scanner/class_element_parser.dart:89:
SourceString getMethodNameHack(Node methodName) {
A method with a name like this *needs* documentation.
Most other methods would benefit too, but here it's completely unobvious what it
does (it returns a Hack?)

https://codereview.chromium.org/11117022/diff/1/dart/lib/compiler/implementat...
dart/lib/compiler/implementation/scanner/class_element_parser.dart:102: if
(receiver == null) {
What is it that isn't implemented?

https://codereview.chromium.org/11117022/diff/1/dart/lib/compiler/implementat...
File dart/lib/compiler/implementation/tree/unparser.dart (right):

https://codereview.chromium.org/11117022/diff/1/dart/lib/compiler/implementat...
dart/lib/compiler/implementation/tree/unparser.dart:274: if (node.argumentsNode
!= null) {
And eventually remove the '+' case when we drop support for that.

[ahe, 2012-10-15 20:39:15]

Thank you for your suggestions. I think Karl already submitted this CL for me
(thank you). So I'll follow up with a new CL to tweak the unparser. 

As for the hack-method, I really hope I can remove it this week.

https://codereview.chromium.org/11117022/diff/1/dart/lib/compiler/implementat...
File dart/lib/compiler/implementation/scanner/class_element_parser.dart (right):

https://codereview.chromium.org/11117022/diff/1/dart/lib/compiler/implementat...
dart/lib/compiler/implementation/scanner/class_element_parser.dart:89:
SourceString getMethodNameHack(Node methodName) {
On 2012/10/15 08:34:37, Lasse Reichstein Nielsen wrote:
> A method with a name like this *needs* documentation.
> Most other methods would benefit too, but here it's completely unobvious what
it
> does (it returns a Hack?)

I have been focused on removing this method. This requires two things: no
mangling of operator names (I already have a CL for that); also, we should store
constructors by their name. I have been working on that, and I think it is
possible now (we only have two factory classes left: String and List).

https://codereview.chromium.org/11117022/diff/1/dart/lib/compiler/implementat...
dart/lib/compiler/implementation/scanner/class_element_parser.dart:102: if
(receiver == null) {
On 2012/10/15 08:34:37, Lasse Reichstein Nielsen wrote:
> What is it that isn't implemented? 

Library prefixes in factory names. The error message will highlight the prefix,
so I think the error message is good enough for now (this method will be removed
ASAP).