Fix a crash related to obsolete factory syntax.

dart/lib/compiler/implementation/scanner/class_element_parser.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class ClassElementParser extends PartialParser {
   ClassElementParser(Listener listener) : super(listener);
 
   Token parseClassBody(Token token) => fullParseClassBody(token);
 }
 
@@ skipping 68 matching lines @@
     SourceString name;
     if (nameNode.asIdentifier() !== null) {
       name = nameNode.asIdentifier().source;
     } else {
       Send send = nameNode.asSend();
       name = send.receiver.asIdentifier().source;
     }
     return enclosingElement.name == name;
   }
 
   SourceString getMethodNameHack(Node methodName) {

[Lasse Reichstein Nielsen, 2012/10/15 08:34:37]

A method with a name like this *needs* documentation.
Most other methods would benefit too, but here it's completely unobvious what it
does (it returns a Hack?)

[ahe, 2012/10/15 20:39:15]

I have been focused on removing this method. This requires two things: no
mangling of operator names (I already have a CL for that); also, we should store
constructors by their name. I have been working on that, and I think it is
possible now (we only have two factory classes left: String and List).

     Send send = methodName.asSend();
     if (send === null) return methodName.asIdentifier().source;
     Identifier receiver = send.receiver.asIdentifier();
     Identifier selector = send.selector.asIdentifier();
     Operator operator = selector.asOperator();
     if (operator !== null) {
       assert(receiver.source.stringValue === 'operator');
       // TODO(ahe): It is a hack to compare to ')', but it beats
       // parsing the node.
       bool isUnary = operator.token.next.next.stringValue === ')';
       return Elements.constructOperatorName(operator.source, isUnary);
     } else {
+      if (receiver == null) {

[Lasse Reichstein Nielsen, 2012/10/15 08:34:37]

What is it that isn't implemented? 

[ahe, 2012/10/15 20:39:15]

Library prefixes in factory names. The error message will highlight the prefix,
so I think the error message is good enough for now (this method will be removed
ASAP).

+        listener.cancel('not implemented', node: send.receiver);
+      }
       return Elements.constructConstructorName(receiver.source,
                                                selector.source);
     }
   }
 
   void endMethod(Token getOrSet, Token beginToken, Token endToken) {
     super.endMethod(getOrSet, beginToken, endToken);
     FunctionExpression method = popNode();
     pushNode(null);
     bool isConstructor = isConstructorName(method.name);
@@ skipping 53 matching lines @@
   }
 
   void addMember(Element memberElement) {
     for (Link link = metadata; !link.isEmpty(); link = link.tail) {
       memberElement.addMetadata(link.head);
     }
     metadata = const Link<MetadataAnnotation>();
     enclosingElement.addMember(memberElement, listener);
   }
 }