Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11111022: Remove TabContents from constrained windows. (Closed)

Created:
8 years, 2 months ago by Avi (use Gerrit)
Modified:
8 years, 2 months ago
Reviewers:
sail, Elliot Glaysher, sky
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, tfarina, Aaron Boodman, groby+watch_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, rouslan+watch_chromium.org, Mike Wittman
Visibility:
Public.

Description

Remove TabContents from constrained windows. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161903

Patch Set 1 #

Patch Set 2 : moar green #

Patch Set 3 : remove unrelated gtk code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -116 lines) Patch
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_controller.mm View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_controller_browsertest.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac2.h View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac2.mm View 4 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window_mac.h View 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window_mac.mm View 6 chunks +12 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/login_prompt_cocoa.mm View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper_unittest.cc View 1 2 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/ui/gtk/collected_cookies_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.h View 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.cc View 6 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/login_prompt_gtk.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
Elliott: gtk Sailesh: mac Scott: win
8 years, 2 months ago (2012-10-12 19:29:02 UTC) #1
Elliot Glaysher
gtk lgtm
8 years, 2 months ago (2012-10-12 19:30:51 UTC) #2
sail
cocoa/* and constrained window changes LGTM. CC: wittman
8 years, 2 months ago (2012-10-12 19:47:14 UTC) #3
sky
LGTM
8 years, 2 months ago (2012-10-15 15:44:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11111022/8001
8 years, 2 months ago (2012-10-15 16:35:15 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-15 18:39:57 UTC) #6 
Change committed as 161903

Powered by Google App Engine
This is Rietveld 408576698