Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: chrome/browser/ui/constrained_window_tab_helper_unittest.cc

Issue 11111022: Remove TabContents from constrained windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove unrelated gtk code Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/constrained_window_tab_helper.cc ('k') | chrome/browser/ui/gtk/collected_cookies_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/constrained_window_tab_helper_unittest.cc
diff --git a/chrome/browser/ui/constrained_window_tab_helper_unittest.cc b/chrome/browser/ui/constrained_window_tab_helper_unittest.cc
index 81ce4314dfada265a74f2dae85aa61689539706b..03fcc706a14a8b0fd78e2d2d0127e6ed836b1589 100644
--- a/chrome/browser/ui/constrained_window_tab_helper_unittest.cc
+++ b/chrome/browser/ui/constrained_window_tab_helper_unittest.cc
@@ -4,28 +4,32 @@
#include "chrome/browser/ui/constrained_window.h"
#include "chrome/browser/ui/constrained_window_tab_helper.h"
-#include "chrome/browser/ui/tab_contents/tab_contents.h"
-#include "chrome/browser/ui/tab_contents/test_tab_contents.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "content/public/test/test_browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
using content::BrowserThread;
-class ConstrainedWindowTabHelperUnit : public TabContentsTestHarness {
+class ConstrainedWindowTabHelperTest : public ChromeRenderViewHostTestHarness {
public:
- ConstrainedWindowTabHelperUnit()
- : TabContentsTestHarness(),
+ ConstrainedWindowTabHelperTest()
+ : ChromeRenderViewHostTestHarness(),
ui_thread_(BrowserThread::UI, &message_loop_) {
}
+ virtual void SetUp() {
+ ChromeRenderViewHostTestHarness::SetUp();
+ ConstrainedWindowTabHelper::CreateForWebContents(web_contents());
+ }
+
private:
content::TestBrowserThread ui_thread_;
};
class ConstrainedWindowCloseTest : public ConstrainedWindow {
public:
- explicit ConstrainedWindowCloseTest(TabContents* tab_contents)
- : tab_contents_(tab_contents) {
+ explicit ConstrainedWindowCloseTest(content::WebContents* web_contents)
+ : web_contents_(web_contents) {
}
virtual void ShowConstrainedWindow() {}
@@ -34,18 +38,17 @@ class ConstrainedWindowCloseTest : public ConstrainedWindow {
virtual void CloseConstrainedWindow() {
ConstrainedWindowTabHelper* constrained_window_tab_helper =
- ConstrainedWindowTabHelper::FromWebContents(
- tab_contents_->web_contents());
+ ConstrainedWindowTabHelper::FromWebContents(web_contents_);
constrained_window_tab_helper->WillClose(this);
close_count++;
}
int close_count;
- TabContents* tab_contents_;
+ content::WebContents* web_contents_;
};
-TEST_F(ConstrainedWindowTabHelperUnit, ConstrainedWindows) {
- ConstrainedWindowCloseTest window(tab_contents());
+TEST_F(ConstrainedWindowTabHelperTest, ConstrainedWindows) {
+ ConstrainedWindowCloseTest window(web_contents());
window.close_count = 0;
ConstrainedWindowTabHelper* constrained_window_tab_helper =
ConstrainedWindowTabHelper::FromWebContents(web_contents());
« no previous file with comments | « chrome/browser/ui/constrained_window_tab_helper.cc ('k') | chrome/browser/ui/gtk/collected_cookies_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698