Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: chrome/browser/ui/constrained_window_tab_helper.cc

Issue 11111022: Remove TabContents from constrained windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove unrelated gtk code Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/constrained_window_tab_helper.h" 5 #include "chrome/browser/ui/constrained_window_tab_helper.h"
6 6
7 #include "chrome/browser/ui/constrained_window.h" 7 #include "chrome/browser/ui/constrained_window.h"
8 #include "chrome/browser/ui/constrained_window_tab_helper_delegate.h" 8 #include "chrome/browser/ui/constrained_window_tab_helper_delegate.h"
9 #include "chrome/browser/ui/tab_contents/tab_contents.h"
10 #include "chrome/common/render_messages.h" 9 #include "chrome/common/render_messages.h"
11 #include "content/public/browser/navigation_details.h" 10 #include "content/public/browser/navigation_details.h"
12 #include "content/public/browser/navigation_entry.h" 11 #include "content/public/browser/navigation_entry.h"
13 #include "content/public/browser/render_view_host.h" 12 #include "content/public/browser/render_view_host.h"
14 #include "content/public/browser/render_widget_host_view.h" 13 #include "content/public/browser/render_widget_host_view.h"
15 #include "content/public/browser/web_contents.h" 14 #include "content/public/browser/web_contents.h"
16 #include "net/base/registry_controlled_domains/registry_controlled_domain.h" 15 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
17 16
18 using content::WebContents; 17 using content::WebContents;
19 18
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 } 104 }
106 } 105 }
107 106
108 void ConstrainedWindowTabHelper::WebContentsDestroyed(WebContents* tab) { 107 void ConstrainedWindowTabHelper::WebContentsDestroyed(WebContents* tab) {
109 // First cleanly close all child windows. 108 // First cleanly close all child windows.
110 // TODO(mpcomplete): handle case if MaybeCloseChildWindows() already asked 109 // TODO(mpcomplete): handle case if MaybeCloseChildWindows() already asked
111 // some of these to close. CloseWindows is async, so it might get called 110 // some of these to close. CloseWindows is async, so it might get called
112 // twice before it runs. 111 // twice before it runs.
113 CloseConstrainedWindows(); 112 CloseConstrainedWindows();
114 } 113 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm ('k') | chrome/browser/ui/constrained_window_tab_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698