Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1110823002: Fix Mojo and Mandoline builds. (Closed)

Created:
5 years, 7 months ago by msw
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Mojo and Mandoline builds. Fixes breaks from two recent CLs: https://codereview.chromium.org/1091513005 https://codereview.chromium.org/1109943002 BUG=NONE TEST=ToT builds mojo and mandoline. R=sky@chromium.org TBR=jam@chromium.org,ben@chromium.org Committed: https://crrev.com/6686fc0814368f17eceb30dcb4fdb6f90efa11e2 Cr-Commit-Position: refs/heads/master@{#327190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M components/kiosk_wm/merged_service_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/desktop/launcher_process.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/app/desktop/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mandoline/services/navigation/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
msw
Hey John and Ben, please take a look; thanks! (I'll ensure CQ and main waterfall ...
5 years, 7 months ago (2015-04-27 23:46:41 UTC) #1
sky
LGTM
5 years, 7 months ago (2015-04-27 23:58:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110823002/1
5 years, 7 months ago (2015-04-27 23:59:15 UTC) #5
jam
lgtm thanks
5 years, 7 months ago (2015-04-28 00:00:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 00:19:13 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 00:20:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6686fc0814368f17eceb30dcb4fdb6f90efa11e2
Cr-Commit-Position: refs/heads/master@{#327190}

Powered by Google App Engine
This is Rietveld 408576698