Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1109943002: Move NavigatorHost interface to mandoline. (Closed)

Created:
5 years, 8 months ago by jam
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move NavigatorHost interface to mandoline. Also remove third_party\mojo_services\src\http_server which is unused. BUG=479353 Committed: https://crrev.com/731d868b22da5daf27bdbbf60bcad7e994c6f036 Cr-Commit-Position: refs/heads/master@{#327153}

Patch Set 1 #

Patch Set 2 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -255 lines) Patch
M components/html_viewer/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M components/html_viewer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/html_document.h View 2 chunks +1 line, -1 line 0 comments Download
M components/kiosk_wm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/kiosk_wm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/kiosk_wm/kiosk_wm.h View 1 chunk +1 line, -1 line 0 comments Download
M components/kiosk_wm/navigator_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + mandoline/services/navigation/public/interfaces/BUILD.gn View 1 1 chunk +6 lines, -2 lines 0 comments Download
A + mandoline/services/navigation/public/interfaces/navigation.mojom View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo_services/src/http_server/public/cpp/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/mojo_services/src/http_server/public/cpp/http_server_util.h View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/mojo_services/src/http_server/public/cpp/lib/http_server_util.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/mojo_services/src/http_server/public/interfaces/BUILD.gn View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/mojo_services/src/http_server/public/interfaces/http_request.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/mojo_services/src/http_server/public/interfaces/http_response.mojom View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/mojo_services/src/http_server/public/interfaces/http_server.mojom View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/mojo_services/src/http_server/public/interfaces/http_server_factory.mojom View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/mojo_services/src/navigation/public/interfaces/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/mojo_services/src/navigation/public/interfaces/navigation.mojom View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jam
5 years, 8 months ago (2015-04-27 19:29:46 UTC) #2
sky
Did you forget to git add mandoline/services?
5 years, 8 months ago (2015-04-27 20:27:41 UTC) #3
jam
On 2015/04/27 20:27:41, sky wrote: > Did you forget to git add mandoline/services? yep, ptal
5 years, 8 months ago (2015-04-27 21:39:13 UTC) #4
sky
LGTM
5 years, 8 months ago (2015-04-27 21:39:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109943002/20001
5 years, 8 months ago (2015-04-27 21:41:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-27 22:12:28 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 22:13:19 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/731d868b22da5daf27bdbbf60bcad7e994c6f036
Cr-Commit-Position: refs/heads/master@{#327153}

Powered by Google App Engine
This is Rietveld 408576698