Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/browser/extensions/fake_safe_browsing_database_manager.h

Issue 1110723002: Split to SafeBrowsingDatabaseManager into Local* and Remote*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to review. Tweak comments and list initializer. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/fake_safe_browsing_database_manager.h
diff --git a/chrome/browser/extensions/fake_safe_browsing_database_manager.h b/chrome/browser/extensions/fake_safe_browsing_database_manager.h
index b890c24c227f47ba6e6b14714d51ee0e0a5c5684..b8d2a97588669ba6fe066816236bf896a941d787 100644
--- a/chrome/browser/extensions/fake_safe_browsing_database_manager.h
+++ b/chrome/browser/extensions/fake_safe_browsing_database_manager.h
@@ -8,7 +8,7 @@
#include <set>
#include <string>
-#include "chrome/browser/safe_browsing/database_manager.h"
+#include "chrome/browser/safe_browsing/local_database_manager.h"
namespace extensions {
@@ -16,7 +16,8 @@ namespace extensions {
//
// By default it is disabled (returning true and ignoring |unsafe_ids_|);
// call set_enabled to enable it.
-class FakeSafeBrowsingDatabaseManager : public SafeBrowsingDatabaseManager {
+class FakeSafeBrowsingDatabaseManager
+ : public LocalSafeBrowsingDatabaseManager {
public:
explicit FakeSafeBrowsingDatabaseManager(bool enabled);
@@ -49,9 +50,8 @@ class FakeSafeBrowsingDatabaseManager : public SafeBrowsingDatabaseManager {
private:
~FakeSafeBrowsingDatabaseManager() override;
- // Runs client->SafeBrowsingResult(result).
- void OnSafeBrowsingResult(scoped_ptr<SafeBrowsingCheck> result,
- Client* client);
+ // Runs result->SafeBrowsingResult().
+ void OnSafeBrowsingResult(scoped_ptr<SafeBrowsingCheck> result);
// Whether to respond to CheckExtensionIDs immediately with true (indicating
// that there is definitely no extension ID match).

Powered by Google App Engine
This is Rietveld 408576698