Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/browser/extensions/fake_safe_browsing_database_manager.h

Issue 1110723002: Split to SafeBrowsingDatabaseManager into Local* and Remote*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to review. Tweak comments and list initializer. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_FAKE_SAFE_BROWSING_DATABASE_MANAGER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_FAKE_SAFE_BROWSING_DATABASE_MANAGER_H_
6 #define CHROME_BROWSER_EXTENSIONS_FAKE_SAFE_BROWSING_DATABASE_MANAGER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_FAKE_SAFE_BROWSING_DATABASE_MANAGER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
11 #include "chrome/browser/safe_browsing/database_manager.h" 11 #include "chrome/browser/safe_browsing/local_database_manager.h"
12 12
13 namespace extensions { 13 namespace extensions {
14 14
15 // A fake safe browsing database manager for use with extensions tests. 15 // A fake safe browsing database manager for use with extensions tests.
16 // 16 //
17 // By default it is disabled (returning true and ignoring |unsafe_ids_|); 17 // By default it is disabled (returning true and ignoring |unsafe_ids_|);
18 // call set_enabled to enable it. 18 // call set_enabled to enable it.
19 class FakeSafeBrowsingDatabaseManager : public SafeBrowsingDatabaseManager { 19 class FakeSafeBrowsingDatabaseManager
20 : public LocalSafeBrowsingDatabaseManager {
20 public: 21 public:
21 explicit FakeSafeBrowsingDatabaseManager(bool enabled); 22 explicit FakeSafeBrowsingDatabaseManager(bool enabled);
22 23
23 // Returns true if synchronously safe, false if not in which case the unsafe 24 // Returns true if synchronously safe, false if not in which case the unsafe
24 // IDs taken from |unsafe_ids_| are passed to to |client| on the current 25 // IDs taken from |unsafe_ids_| are passed to to |client| on the current
25 // message loop. 26 // message loop.
26 bool CheckExtensionIDs(const std::set<std::string>& extension_ids, 27 bool CheckExtensionIDs(const std::set<std::string>& extension_ids,
27 Client* client) override; 28 Client* client) override;
28 29
29 // Return |this| to chain together SetUnsafe(...).NotifyUpdate() conveniently. 30 // Return |this| to chain together SetUnsafe(...).NotifyUpdate() conveniently.
(...skipping 12 matching lines...) Expand all
42 const std::string& d); 43 const std::string& d);
43 FakeSafeBrowsingDatabaseManager& AddUnsafe(const std::string& a); 44 FakeSafeBrowsingDatabaseManager& AddUnsafe(const std::string& a);
44 FakeSafeBrowsingDatabaseManager& RemoveUnsafe(const std::string& a); 45 FakeSafeBrowsingDatabaseManager& RemoveUnsafe(const std::string& a);
45 46
46 // Send the update notification. 47 // Send the update notification.
47 void NotifyUpdate(); 48 void NotifyUpdate();
48 49
49 private: 50 private:
50 ~FakeSafeBrowsingDatabaseManager() override; 51 ~FakeSafeBrowsingDatabaseManager() override;
51 52
52 // Runs client->SafeBrowsingResult(result). 53 // Runs result->SafeBrowsingResult().
53 void OnSafeBrowsingResult(scoped_ptr<SafeBrowsingCheck> result, 54 void OnSafeBrowsingResult(scoped_ptr<SafeBrowsingCheck> result);
54 Client* client);
55 55
56 // Whether to respond to CheckExtensionIDs immediately with true (indicating 56 // Whether to respond to CheckExtensionIDs immediately with true (indicating
57 // that there is definitely no extension ID match). 57 // that there is definitely no extension ID match).
58 bool enabled_; 58 bool enabled_;
59 59
60 // The extension IDs considered unsafe. 60 // The extension IDs considered unsafe.
61 std::set<std::string> unsafe_ids_; 61 std::set<std::string> unsafe_ids_;
62 }; 62 };
63 63
64 } // namespace extensions 64 } // namespace extensions
65 65
66 #endif // CHROME_BROWSER_EXTENSIONS_FAKE_SAFE_BROWSING_DATABASE_MANAGER_H_ 66 #endif // CHROME_BROWSER_EXTENSIONS_FAKE_SAFE_BROWSING_DATABASE_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698