Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5053)

Unified Diff: chrome/browser/extensions/fake_safe_browsing_database_manager.cc

Issue 1110723002: Split to SafeBrowsingDatabaseManager into Local* and Remote*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to review. Tweak comments and list initializer. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/fake_safe_browsing_database_manager.cc
diff --git a/chrome/browser/extensions/fake_safe_browsing_database_manager.cc b/chrome/browser/extensions/fake_safe_browsing_database_manager.cc
index 7a02e5cfa304ddc6bcc1fc0de5161324585bc9ae..0897401b7448af8aebaac22449c3f71a22667610 100644
--- a/chrome/browser/extensions/fake_safe_browsing_database_manager.cc
+++ b/chrome/browser/extensions/fake_safe_browsing_database_manager.cc
@@ -18,7 +18,7 @@
namespace extensions {
FakeSafeBrowsingDatabaseManager::FakeSafeBrowsingDatabaseManager(bool enabled)
- : SafeBrowsingDatabaseManager(
+ : LocalSafeBrowsingDatabaseManager(
make_scoped_refptr(SafeBrowsingService::CreateSafeBrowsingService())),
enabled_(enabled) {
}
@@ -84,7 +84,7 @@ FakeSafeBrowsingDatabaseManager& FakeSafeBrowsingDatabaseManager::RemoveUnsafe(
}
void FakeSafeBrowsingDatabaseManager::NotifyUpdate() {
- SafeBrowsingDatabaseManager::NotifyDatabaseUpdateFinished(true);
+ LocalSafeBrowsingDatabaseManager::NotifyDatabaseUpdateFinished(true);
}
bool FakeSafeBrowsingDatabaseManager::CheckExtensionIDs(
@@ -118,17 +118,14 @@ bool FakeSafeBrowsingDatabaseManager::CheckExtensionIDs(
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
- base::Bind(&FakeSafeBrowsingDatabaseManager::OnSafeBrowsingResult,
- this,
- base::Passed(&safe_browsing_check),
- client));
+ base::Bind(&FakeSafeBrowsingDatabaseManager::OnSafeBrowsingResult, this,
+ base::Passed(&safe_browsing_check)));
return false;
}
void FakeSafeBrowsingDatabaseManager::OnSafeBrowsingResult(
- scoped_ptr<SafeBrowsingCheck> result,
- Client* client) {
- client->OnSafeBrowsingResult(*result);
+ scoped_ptr<SafeBrowsingCheck> result) {
+ result->OnSafeBrowsingResult();
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698