Issue 1110433002: Make Isolate as the first argument.

Issue 1110433002: Make Isolate as the first argument. (Closed)

Created:
5 years, 8 months ago by deepak.s

Modified:
5 years, 8 months ago

Reviewers:
haraken, vivekg

CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Make Isolate as the first argument. As v8::isolate is not a optional argument anymore, move isolate to first argumnet of methods in bindings/. BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194505

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
M	Source/bindings/core/v8/DOMDataStore.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/core/v8/DOMWrapperMap.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/core/v8/V8Binding.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/core/v8/V8NPObject.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/core/v8/V8ValueCache.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/core/v8/WindowProxy.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/core/v8/WindowProxy.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/core/v8/WindowProxyManager.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110433002/20001

5 years, 8 months ago (2015-04-27 09:39:54 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-27 10:26:18 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194505