Source/bindings/core/v8/V8ValueCache.h - Issue 1110433002: Make Isolate as the first argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8ValueCache.h

Issue 1110433002: Make Isolate as the first argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix Compile error Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8ValueCache.h

diff --git a/Source/bindings/core/v8/V8ValueCache.h b/Source/bindings/core/v8/V8ValueCache.h

index 5b5ccfc9c7f72131d15be79ecf2aa3ca3e5ec5a6..ce0d1a14870ff6212909caef51f62210711afebe 100644

--- a/Source/bindings/core/v8/V8ValueCache.h

+++ b/Source/bindings/core/v8/V8ValueCache.h

@@ -67,7 +67,7 @@ public:

StringCache(v8::Isolate* isolate) : m_stringCache(isolate) { }

~StringCache();

- v8::Local<v8::String> v8ExternalString(StringImpl* stringImpl, v8::Isolate* isolate)

+ v8::Local<v8::String> v8ExternalString(v8::Isolate* isolate, StringImpl* stringImpl)

{

ASSERT(stringImpl);

if (m_lastStringImpl.get() == stringImpl)

« no previous file with comments | « Source/bindings/core/v8/V8NPObject.cpp ('k') | Source/bindings/core/v8/WindowProxy.h » ('j') | no next file with comments »