Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: Source/bindings/core/v8/V8NPObject.cpp

Issue 1110433002: Make Isolate as the first argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix Compile error Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8ValueCache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8NPObject.cpp
diff --git a/Source/bindings/core/v8/V8NPObject.cpp b/Source/bindings/core/v8/V8NPObject.cpp
index bfb67dc3771518ad0bb8e950b767cb4e78969be5..9a28df3f2900d5c7a10799bc5b770a68a6fafe36 100644
--- a/Source/bindings/core/v8/V8NPObject.cpp
+++ b/Source/bindings/core/v8/V8NPObject.cpp
@@ -456,7 +456,7 @@ v8::Local<v8::Object> createV8ObjectForNPObject(v8::Isolate* isolate, NPObject*
return v8::Local<v8::Object>::New(isolate, v8NPObject->v8Object);
// If we've already wrapped this object, just return it.
- v8::Local<v8::Object> wrapper = staticNPObjectMap().newLocal(object, isolate);
+ v8::Local<v8::Object> wrapper = staticNPObjectMap().newLocal(isolate, object);
if (!wrapper.IsEmpty())
return wrapper;
@@ -498,7 +498,7 @@ void forgetV8ObjectForNPObject(NPObject* object)
{
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::HandleScope scope(isolate);
- v8::Local<v8::Object> wrapper = staticNPObjectMap().newLocal(object, isolate);
+ v8::Local<v8::Object> wrapper = staticNPObjectMap().newLocal(isolate, object);
if (!wrapper.IsEmpty()) {
V8DOMWrapper::clearNativeInfo(wrapper, npObjectTypeInfo());
staticNPObjectMap().removeAndDispose(object);
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8ValueCache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698