Issue 1110353003: Fix build warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code;…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1110353003: Fix build warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code;… (Closed)

Created:
5 years, 7 months ago by dshwang

Modified:
5 years, 7 months ago

Reviewers:
bsalomon, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Fix build warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare] Committed: https://skia.googlesource.com/skia/+/181d7ba4cdb55e3fd53811200d5f7beb362b2437

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -6 lines)			Patch
M	src/core/SkImageFilter.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/core/SkPaint.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/core/SkPath.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/core/SkStroke.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110353003/1

5 years, 7 months ago (2015-04-30 12:48:20 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-04-30 12:53:33 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/181d7ba4cdb55e3fd53811200d5f7beb362b2437