src/core/SkPaint.cpp - Issue 1110353003: Fix build warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code;…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPaint.cpp

Issue 1110353003: Fix build warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code;… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkPaint.cpp

diff --git a/src/core/SkPaint.cpp b/src/core/SkPaint.cpp

index e072385f30306995c423c7e818b0c3a624614001..975d0ccc07ee536bea45a4819a447bb308013f87 100644

--- a/src/core/SkPaint.cpp

+++ b/src/core/SkPaint.cpp

@@ -116,8 +116,6 @@ SkPaint& SkPaint::operator=(const SkPaint& src) {

#define COPY(field) field = src.field

#define REF_COPY(field) SkSafeUnref(field); field = SkSafeRef(src.field)

- SkASSERT(&src);

REF_COPY(fTypeface);

REF_COPY(fPathEffect);

REF_COPY(fShader);

« no previous file with comments | « src/core/SkImageFilter.cpp ('k') | src/core/SkPath.cpp » ('j') | no next file with comments »