src/core/SkPath.cpp - Issue 1110353003: Fix build warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code;…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPath.cpp

Issue 1110353003: Fix build warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code;… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkPath.cpp

diff --git a/src/core/SkPath.cpp b/src/core/SkPath.cpp

index aa99ce4f0e1da80840eededc3cfb82bc9c97a00d..812b49bf3b7bb146d0f7eb884952b41661118212 100644

--- a/src/core/SkPath.cpp

+++ b/src/core/SkPath.cpp

@@ -179,8 +179,6 @@ bool operator==(const SkPath& a, const SkPath& b) {

}

void SkPath::swap(SkPath& that) {

- SkASSERT(&that != NULL);

if (this != &that) {

fPathRef.swap(&that.fPathRef);

SkTSwap<int>(fLastMoveToIndex, that.fLastMoveToIndex);

« no previous file with comments | « src/core/SkPaint.cpp ('k') | src/core/SkStroke.cpp » ('j') | no next file with comments »