Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1110313002: [chrome/browser] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in icon_loader files of chrome/browser module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/4b8db4d04e9604f90f6e616689e936d0b7262622 Cr-Commit-Position: refs/heads/master@{#327470}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed Review Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/icon_loader.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/icon_loader.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/icon_loader_auralinux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/icon_loader_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/icon_loader_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/icon_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-04-29 05:53:33 UTC) #2
Lei Zhang
https://codereview.chromium.org/1110313002/diff/1/chrome/browser/icon_loader.h File chrome/browser/icon_loader.h (right): https://codereview.chromium.org/1110313002/diff/1/chrome/browser/icon_loader.h#newcode90 chrome/browser/icon_loader.h:90: // The message loop object of the thread in ...
5 years, 7 months ago (2015-04-29 07:48:17 UTC) #3
Pranay
Thanks Lei for the review. Updated the comments. PTAL
5 years, 7 months ago (2015-04-29 07:56:27 UTC) #4
Lei Zhang
lgtm Feel free to do the conversion for more than a single class in a ...
5 years, 7 months ago (2015-04-29 08:01:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110313002/20001
5 years, 7 months ago (2015-04-29 09:21:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-29 11:12:14 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4b8db4d04e9604f90f6e616689e936d0b7262622 Cr-Commit-Position: refs/heads/master@{#327470}
5 years, 7 months ago (2015-04-29 11:13:09 UTC) #9
Pranay
5 years, 7 months ago (2015-05-04 03:29:08 UTC) #10
Message was sent while issue was closed.
Done

https://codereview.chromium.org/1110313002/diff/1/chrome/browser/icon_loader.h
File chrome/browser/icon_loader.h (right):

https://codereview.chromium.org/1110313002/diff/1/chrome/browser/icon_loader....
chrome/browser/icon_loader.h:90: // The message loop object of the thread in
which we notify the delegate.
On 2015/04/29 07:48:17, Lei Zhang wrote:
> Please update the comment.

Done.

Powered by Google App Engine
This is Rietveld 408576698