Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: chrome/browser/icon_loader.cc

Issue 1110313002: [chrome/browser] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Review Comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/icon_loader.h ('k') | chrome/browser/icon_loader_auralinux.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/icon_loader.h" 5 #include "chrome/browser/icon_loader.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/thread_task_runner_handle.h"
9 #include "content/public/browser/browser_thread.h" 10 #include "content/public/browser/browser_thread.h"
10 11
11 using content::BrowserThread; 12 using content::BrowserThread;
12 13
13 IconLoader::IconLoader(const base::FilePath& file_path, 14 IconLoader::IconLoader(const base::FilePath& file_path,
14 IconSize size, 15 IconSize size,
15 Delegate* delegate) 16 Delegate* delegate)
16 : target_message_loop_(NULL), 17 : target_task_runner_(NULL),
17 file_path_(file_path), 18 file_path_(file_path),
18 icon_size_(size), 19 icon_size_(size),
19 delegate_(delegate) {} 20 delegate_(delegate) {}
20 21
21 IconLoader::~IconLoader() { 22 IconLoader::~IconLoader() {
22 } 23 }
23 24
24 void IconLoader::Start() { 25 void IconLoader::Start() {
25 target_message_loop_ = base::MessageLoopProxy::current(); 26 target_task_runner_ = base::ThreadTaskRunnerHandle::Get();
26 27
27 BrowserThread::PostTaskAndReply(BrowserThread::FILE, FROM_HERE, 28 BrowserThread::PostTaskAndReply(BrowserThread::FILE, FROM_HERE,
28 base::Bind(&IconLoader::ReadGroup, this), 29 base::Bind(&IconLoader::ReadGroup, this),
29 base::Bind(&IconLoader::OnReadGroup, this)); 30 base::Bind(&IconLoader::OnReadGroup, this));
30 } 31 }
31 32
32 void IconLoader::ReadGroup() { 33 void IconLoader::ReadGroup() {
33 group_ = ReadGroupIDFromFilepath(file_path_); 34 group_ = ReadGroupIDFromFilepath(file_path_);
34 } 35 }
35 36
36 void IconLoader::OnReadGroup() { 37 void IconLoader::OnReadGroup() {
37 if (IsIconMutableFromFilepath(file_path_) || 38 if (IsIconMutableFromFilepath(file_path_) ||
38 !delegate_->OnGroupLoaded(this, group_)) { 39 !delegate_->OnGroupLoaded(this, group_)) {
39 BrowserThread::PostTask(ReadIconThreadID(), FROM_HERE, 40 BrowserThread::PostTask(ReadIconThreadID(), FROM_HERE,
40 base::Bind(&IconLoader::ReadIcon, this)); 41 base::Bind(&IconLoader::ReadIcon, this));
41 } 42 }
42 } 43 }
43 44
44 void IconLoader::NotifyDelegate() { 45 void IconLoader::NotifyDelegate() {
45 // If the delegate takes ownership of the Image, release it from the scoped 46 // If the delegate takes ownership of the Image, release it from the scoped
46 // pointer. 47 // pointer.
47 if (delegate_->OnImageLoaded(this, image_.get(), group_)) 48 if (delegate_->OnImageLoaded(this, image_.get(), group_))
48 ignore_result(image_.release()); // Can't ignore return value. 49 ignore_result(image_.release()); // Can't ignore return value.
49 } 50 }
OLDNEW
« no previous file with comments | « chrome/browser/icon_loader.h ('k') | chrome/browser/icon_loader_auralinux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698