chrome/browser/icon_loader_mac.mm - Issue 1110313002: [chrome/browser] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/icon_loader_mac.mm

Issue 1110313002: [chrome/browser] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Review Comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/icon_loader_chromeos.cc ('k') | chrome/browser/icon_loader_win.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/icon_loader.h"	5 #include "chrome/browser/icon_loader.h"

6	6

7 #import <AppKit/AppKit.h>	7 #import <AppKit/AppKit.h>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/files/file_path.h"	10 #include "base/files/file_path.h"

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50 default:	50 default:

51 NOTREACHED();	51 NOTREACHED();

52 }	52 }

53 gfx::ImageSkia image_skia(gfx::ImageSkiaFromResizedNSImage(icon, size));	53 gfx::ImageSkia image_skia(gfx::ImageSkiaFromResizedNSImage(icon, size));

54 if (!image_skia.isNull()) {	54 if (!image_skia.isNull()) {

55 image_skia.MakeThreadSafe();	55 image_skia.MakeThreadSafe();

56 image_.reset(new gfx::Image(image_skia));	56 image_.reset(new gfx::Image(image_skia));

57 }	57 }

58 }	58 }

59	59

60 target_message_loop_->PostTask(FROM_HERE,	60 target_task_runner_->PostTask(FROM_HERE,

61 base::Bind(&IconLoader::NotifyDelegate, this));	61 base::Bind(&IconLoader::NotifyDelegate, this));

62 }	62 }

OLD	NEW