Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 11099038: Merge 130513 - [chromium] Only inflate the height of rows in a popup menu when a touch device is de… (Closed)

Created:
8 years, 2 months ago by rjkroege
Modified:
8 years, 2 months ago
Reviewers:
kevers
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 130513 - [chromium] Only inflate the height of rows in a popup menu when a touch device is detected. https://bugs.webkit.org/show_bug.cgi?id=98515 Patch by Kevin Ellis <kevers@chromium.org>; on 2012-10-05 Reviewed by Adam Barth. Enforces a minimum row height for popup menus when a touch device is detected. In a previous patch (r127597), the sizing of popup was consolidated for touch and non-touch. Based on user feedback, reverting to the old behavior for non-touch and only adding padding for touch devices seems like a much safer strategy. This patch is not a direct revert of r127567 since the padding previously used for touch is a bit excessive. Covered by existing tests. * platform/chromium/PopupListBox.cpp: (WebCore::PopupListBox::getRowHeight): * platform/chromium/PopupMenuChromium.cpp: (WebCore): * platform/chromium/PopupMenuChromium.h: (WebCore::PopupMenuChromium::optionRowHeightForTouch): (WebCore::PopupMenuChromium::setOptionRowHeightForTouch): (PopupMenuChromium): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M Source/WebCore/platform/chromium/PopupListBox.cpp View 2 chunks +7 lines, -3 lines 0 comments Download
M Source/WebCore/platform/chromium/PopupMenuChromium.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/WebCore/platform/chromium/PopupMenuChromium.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
rjkroege
8 years, 2 months ago (2012-10-10 16:09:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698