Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Source/WebCore/platform/chromium/PopupMenuChromium.cpp

Issue 11099038: Merge 130513 - [chromium] Only inflate the height of rows in a popup menu when a touch device is de… (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/platform/chromium/PopupMenuChromium.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved. 2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 22 matching lines...) Expand all
33 #include "PopupMenuChromium.h" 33 #include "PopupMenuChromium.h"
34 34
35 #include "Frame.h" 35 #include "Frame.h"
36 #include "FrameView.h" 36 #include "FrameView.h"
37 #include "Page.h" 37 #include "Page.h"
38 #include "PopupContainer.h" 38 #include "PopupContainer.h"
39 #include "Settings.h" 39 #include "Settings.h"
40 40
41 namespace WebCore { 41 namespace WebCore {
42 42
43 int PopupMenuChromium::s_minimumRowHeight = 28; 43 int PopupMenuChromium::s_minimumRowHeight = 0;
44 int PopupMenuChromium::s_optionRowHeightForTouch = 28;
44 45
45 // The settings used for the drop down menu. 46 // The settings used for the drop down menu.
46 // This is the delegate used if none is provided. 47 // This is the delegate used if none is provided.
47 static const PopupContainerSettings dropDownSettings = { 48 static const PopupContainerSettings dropDownSettings = {
48 true, // setTextOnIndexChange 49 true, // setTextOnIndexChange
49 true, // acceptOnAbandon 50 true, // acceptOnAbandon
50 false, // loopSelectionNavigation 51 false, // loopSelectionNavigation
51 false // restrictWidthOfListBox 52 false // restrictWidthOfListBox
52 }; 53 };
53 54
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 p.popup->listBox()->updateFromElement(); 88 p.popup->listBox()->updateFromElement();
88 } 89 }
89 90
90 91
91 void PopupMenuChromium::disconnectClient() 92 void PopupMenuChromium::disconnectClient()
92 { 93 {
93 m_popupClient = 0; 94 m_popupClient = 0;
94 } 95 }
95 96
96 } // namespace WebCore 97 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/WebCore/platform/chromium/PopupMenuChromium.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698