Issue 1109693002: Ensure MimeHandlerView plugins load properly with long URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1109693002: Ensure MimeHandlerView plugins load properly with long URLs (Closed)

Created:
5 years, 8 months ago by raymes

Modified:
5 years, 8 months ago

Reviewers:

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2357

Target Ref:
refs/pending/branch-heads/2357

Project:
chromium

Visibility:
Public.

More Reviews

Description

Ensure MimeHandlerView plugins load properly with long URLs Currently if a URL which is handled by a MimeHandlerView is too long, mojo will refuse to send the string inside the StreamDetails which are sent to the renderer. In these cases we truncate the URL which gets sent. BUG=478389 Review URL: https://codereview.chromium.org/1062283003 Cr-Commit-Position: refs/heads/master@{#326468} (cherry picked from commit b9a01b52a30232e1b0c9afeafb5ce99138d815e5) Committed: https://chromium.googlesource.com/chromium/src/+/e1e37a494f248a8ebb7faccde02d0da16791728b

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -2 lines)			Patch
M	chrome/test/data/extensions/api_test/mime_handler_view/index.js	View	3 chunks	+17 lines, -1 line	0 comments	Download
A	chrome/test/data/extensions/api_test/mime_handler_view/test_embedded_data_url_long.html	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	extensions/browser/api/mime_handler_private/mime_handler_private.cc	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

raymes

5 years, 8 months ago (2015-04-27 01:05:53 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e1e37a494f248a8ebb7faccde02d0da16791728b.

Expand Messages | Collapse Messages