Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1062283003: Ensure MimeHandlerView plugins load properly with long URLs (Closed)

Created:
5 years, 8 months ago by raymes
Modified:
5 years, 8 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure MimeHandlerView plugins load properly with long URLs Currently if a URL which is handled by a MimeHandlerView is too long, mojo will refuse to send the string inside the StreamDetails which are sent to the renderer. In these cases we truncate the URL which gets sent. BUG=478389 Committed: https://crrev.com/b9a01b52a30232e1b0c9afeafb5ce99138d815e5 Cr-Commit-Position: refs/heads/master@{#326468}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M chrome/test/data/extensions/api_test/mime_handler_view/index.js View 1 2 3 3 chunks +17 lines, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/mime_handler_view/test_embedded_data_url_long.html View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/mime_handler_private/mime_handler_private.cc View 1 2 3 2 chunks +13 lines, -1 line 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
raymes
PTAL I'd like to land this even though I don't know the root cause yet ...
5 years, 8 months ago (2015-04-23 04:28:27 UTC) #2
raymes
(also I filed https://code.google.com/p/chromium/issues/detail?id=480099)
5 years, 8 months ago (2015-04-23 04:29:03 UTC) #3
Sam McNally
lgtm
5 years, 8 months ago (2015-04-23 04:59:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062283003/60001
5 years, 8 months ago (2015-04-23 05:01:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/58396)
5 years, 8 months ago (2015-04-23 05:52:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062283003/80001
5 years, 8 months ago (2015-04-23 06:05:51 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-23 07:18:36 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 07:19:34 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b9a01b52a30232e1b0c9afeafb5ce99138d815e5
Cr-Commit-Position: refs/heads/master@{#326468}

Powered by Google App Engine
This is Rietveld 408576698