Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7542)

Unified Diff: chrome/test/data/extensions/api_test/mime_handler_view/index.js

Issue 1109693002: Ensure MimeHandlerView plugins load properly with long URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2357
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/mime_handler_view/test_embedded_data_url_long.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/mime_handler_view/index.js
diff --git a/chrome/test/data/extensions/api_test/mime_handler_view/index.js b/chrome/test/data/extensions/api_test/mime_handler_view/index.js
index a5b8e4e92eb9b8f3b6a273634a8534cff84134d2..1fbe6202b734021002f09649358b577db1eb55a2 100644
--- a/chrome/test/data/extensions/api_test/mime_handler_view/index.js
+++ b/chrome/test/data/extensions/api_test/mime_handler_view/index.js
@@ -38,6 +38,11 @@ function expectSuccessfulRead(response) {
chrome.test.assertEq('content to read\n', response.data);
}
+function expectSuccessfulReadLong(response) {
+ chrome.test.assertEq(200, response.status);
+ chrome.test.assertTrue(response.data.indexOf('content to read\n') === 0);
+}
+
function checkStreamDetails(name, embedded) {
checkStreamDetailsNoFile();
chrome.test.assertEq(embedded, streamDetails.embedded);
@@ -128,6 +133,13 @@ var tests = [
fetchUrl(streamDetails.streamUrl)
.then(expectSuccessfulRead)
.then(chrome.test.succeed);
+ },
+
+ function testDataUrlLong() {
+ checkStreamDetailsNoFile();
+ fetchUrl(streamDetails.streamUrl)
+ .then(expectSuccessfulReadLong)
+ .then(chrome.test.succeed);
}
];
@@ -153,6 +165,10 @@ chrome.mimeHandlerPrivate.getStreamInfo(function(streamInfo) {
// Run the test for data URLs.
if (streamInfo.originalUrl.indexOf("data:") === 0) {
window.removeEventListener('message', queueMessage);
- chrome.test.runTests([testsByName['testDataUrl']]);
+ // Long data URLs get truncated.
+ if (streamInfo.originalUrl == "data:")
+ chrome.test.runTests([testsByName['testDataUrlLong']]);
+ else
+ chrome.test.runTests([testsByName['testDataUrl']]);
}
});
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/mime_handler_view/test_embedded_data_url_long.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698