Fix padding and touch effects in search engine dialog.

Fix padding and touch effects in search engine dialog.

On pre-L devices, each item in the list of search engines had too much
top padding and no bottom padding. Also, on all devices, clicking a
search engine didn't show a ripple or highlight. Both of these bugs have
been fixed.

BUG=482193
Committed: https://crrev.com/83d6dbf455c300292a11b51158606dcd9826759b
Cr-Commit-Position: refs/heads/master@{#327522}

[newt (away), 2015-04-28 23:57:52]

newt@chromium.org changed reviewers:
+ finnur@chromium.org

[newt (away), 2015-04-28 23:57:52]

PTAL

[newt (away), 2015-04-29 00:02:25]

Screenshots are on the bug:
https://code.google.com/p/chromium/issues/detail?id=482193#c2

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/search_engine.xml (right):

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/search_engine.xml:7:
android:layout_width="match_parent"
the width needs to be match_parent so the entire row is highlighted when pressed

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/search_engine.xml:9:
android:background="?android:attr/selectableItemBackground"
This background causes the highlight/ripple effect when pressed. Additionally,
this LinearLayout needs to be clickable for the effect to occur; hence the
changes in SearchEngineAdapter.java.

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/search_engine.xml:15: <RadioButton
the radio button is now centered vertically with respect to the search engine
title and link

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
(left):

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:233:
TemplateUrl templateUrl = mSearchEngines.get(mSelectedSearchEnginePosition);
dead code

[Finnur, 2015-04-29 09:55:13]

Thanks! LGTM. Two questions below.

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/search_engine.xml (right):

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/search_engine.xml:9:
android:background="?android:attr/selectableItemBackground"
Awesome. Does this fix http://crbug.com/474695. I haven't had a chance to take a
look at it again...

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
(left):

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:181:
description.setTag(position);
Just to confirm... clicking on the description still selects the radio-button,
right?

[newt (away), 2015-04-29 17:33:05]

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/search_engine.xml (right):

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/search_engine.xml:9:
android:background="?android:attr/selectableItemBackground"
On 2015/04/29 09:55:13, Finnur wrote:
> Awesome. Does this fix http://crbug.com/474695. I haven't had a chance to take
a
> look at it again...

Nope. Sadly. I looked at that issue briefly, but I'm still not sure what's
causing it.

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
(left):

https://codereview.chromium.org/1109263004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:181:
description.setTag(position);
On 2015/04/29 09:55:13, Finnur wrote:
> Just to confirm... clicking on the description still selects the radio-button,
> right?

Yes. Click events are first sent to the deepest view in the hierarchy, and as
long as the event hasn't been handled, are slowly propagated up the hierarchy.

[newt (away), 2015-04-29 17:33:08]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-04-29 17:33:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1109263004/1

[commit-bot: I haz the power, 2015-04-29 18:07:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-29 18:07:59]

Patchset 1 (id:??) landed as
https://crrev.com/83d6dbf455c300292a11b51158606dcd9826759b
Cr-Commit-Position: refs/heads/master@{#327522}