Fix padding and touch effects in search engine dialog.

chrome/android/java/res/layout/search_engine.xml

Index: chrome/android/java/res/layout/search_engine.xml
diff --git a/chrome/android/java/res/layout/search_engine.xml b/chrome/android/java/res/layout/search_engine.xml
index c23050b39afbcdfa648c197227a89b8010335ced..27ef6f08745c13d16707d7362384ab1499b3dcc0 100644
--- a/chrome/android/java/res/layout/search_engine.xml
+++ b/chrome/android/java/res/layout/search_engine.xml
@@ -1,36 +1,39 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
-     found in the LICENSE file.
- -->
+     found in the LICENSE file. -->
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    android:layout_width="wrap_content"
+    android:layout_width="match_parent"

[newt (away), 2015/04/29 00:02:25]

the width needs to be match_parent so the entire row is highlighted when pressed

     android:layout_height="wrap_content"
-    android:orientation="vertical">
+    android:background="?android:attr/selectableItemBackground"

[newt (away), 2015/04/29 00:02:25]

This background causes the highlight/ripple effect when pressed. Additionally,
this LinearLayout needs to be clickable for the effect to occur; hence the
changes in SearchEngineAdapter.java.

[Finnur, 2015/04/29 09:55:13]

Awesome. Does this fix http://crbug.com/474695. I haven't had a chance to take a
look at it again...

[newt (away), 2015/04/29 17:33:05]

Nope. Sadly. I looked at that issue briefly, but I'm still not sure what's
causing it.

+    android:gravity="center_vertical"
+    android:orientation="horizontal"
+    android:paddingTop="6dp"
+    android:paddingBottom="6dp">
 
-    <LinearLayout
+    <RadioButton

[newt (away), 2015/04/29 00:02:25]

the radio button is now centered vertically with respect to the search engine
title and link

+        android:id="@+id/radiobutton"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:orientation="horizontal"
-        android:layout_marginTop="22dp">
-        <RadioButton
-            android:id="@+id/radiobutton"
-            android:layout_width="27sp"
-            android:layout_height="23sp"
-            android:layout_marginStart="21dp"
-            android:layout_marginEnd="21dp" />
+        android:layout_marginStart="21dp"
+        android:layout_marginEnd="16dp" />
+
+    <LinearLayout
+        android:layout_width="0dp"
+        android:layout_height="wrap_content"
+        android:layout_weight="1"
+        android:orientation="vertical">
         <TextView
             android:id="@+id/description"
             android:layout_width="wrap_content"
-            android:layout_height="match_parent"
+            android:layout_height="wrap_content"
             android:textSize="17sp" />
+        <TextView
+            android:id="@+id/link"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginEnd="21dp" />
     </LinearLayout>
 
-    <TextView
-        android:id="@+id/link"
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:layout_marginStart="70dp"
-        android:layout_marginEnd="21dp" />
 </LinearLayout>