chrome/android/java/res/layout/search_engine.xml - Issue 1109263004: Fix padding and touch effects in search engine dialog.

Side by Side Diff: chrome/android/java/res/layout/search_engine.xml

Issue 1109263004: Fix padding and touch effects in search engine dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file. -->

5 -->

6	5

7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

8 android:layout_width="wrap_content"	7 android:layout_width="match_parent"
	newt (away) 2015/04/29 00:02:25 the width needs to be match_parent so the entire r the width needs to be match_parent so the entire row is highlighted when pressed
9 android:layout_height="wrap_content"	8 android:layout_height="wrap_content"

10 android:orientation="vertical">	9 android:background="?android:attr/selectableItemBackground"
	newt (away) 2015/04/29 00:02:25 This background causes the highlight/ripple effect This background causes the highlight/ripple effect when pressed. Additionally, this LinearLayout needs to be clickable for the effect to occur; hence the changes in SearchEngineAdapter.java. Finnur 2015/04/29 09:55:13 Awesome. Does this fix http://crbug.com/474695. I Awesome. Does this fix http://crbug.com/474695. I haven't had a chance to take a look at it again... newt (away) 2015/04/29 17:33:05 Nope. Sadly. I looked at that issue briefly, but I Show quoted text On 2015/04/29 09:55:13, Finnur wrote: > Awesome. Does this fix http://crbug.com/474695. I haven't had a chance to take a > look at it again... Nope. Sadly. I looked at that issue briefly, but I'm still not sure what's causing it.
	10 android:gravity="center_vertical"

	11 android:orientation="horizontal"

	12 android:paddingTop="6dp"

	13 android:paddingBottom="6dp">

	14

	15 <RadioButton
	newt (away) 2015/04/29 00:02:25 the radio button is now centered vertically with r the radio button is now centered vertically with respect to the search engine title and link
	16 android:id="@+id/radiobutton"

	17 android:layout_width="wrap_content"

	18 android:layout_height="wrap_content"

	19 android:layout_marginStart="21dp"

	20 android:layout_marginEnd="16dp" />

11	21

12 <LinearLayout	22 <LinearLayout

13 android:layout_width="wrap_content"	23 android:layout_width="0dp"

14 android:layout_height="wrap_content"	24 android:layout_height="wrap_content"

15 android:orientation="horizontal"	25 android:layout_weight="1"

16 android:layout_marginTop="22dp">	26 android:orientation="vertical">

17 <RadioButton

18 android:id="@+id/radiobutton"

19 android:layout_width="27sp"

20 android:layout_height="23sp"

21 android:layout_marginStart="21dp"

22 android:layout_marginEnd="21dp" />

23 <TextView	27 <TextView

24 android:id="@+id/description"	28 android:id="@+id/description"

25 android:layout_width="wrap_content"	29 android:layout_width="wrap_content"

26 android:layout_height="match_parent"	30 android:layout_height="wrap_content"

27 android:textSize="17sp" />	31 android:textSize="17sp" />

	32 <TextView

	33 android:id="@+id/link"

	34 android:layout_width="wrap_content"

	35 android:layout_height="wrap_content"

	36 android:layout_marginEnd="21dp" />

28 </LinearLayout>	37 </LinearLayout>

29	38

30 <TextView

31 android:id="@+id/link"

32 android:layout_width="match_parent"

33 android:layout_height="wrap_content"

34 android:layout_marginStart="70dp"

35 android:layout_marginEnd="21dp" />

36 </LinearLayout>	39 </LinearLayout>

OLD	NEW