Issue 11092101: Diagnose unbalanced parentheses better.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11092101: Diagnose unbalanced parentheses better. (Closed)

Created:
8 years, 2 months ago by ahe

Modified:
8 years ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Diagnose unbalanced parentheses better. Committed: https://code.google.com/p/dart/source/detail?r=15386

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -4 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/scanner/array_based_scanner.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/token.dart	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

This fixes http://dartbug.com/5829. Tested by looking at the error message. In addition, this code is ...

8 years, 2 months ago (2012-10-12 11:21:06 UTC) #1

floitsch

8 years, 2 months ago (2012-10-12 12:23:28 UTC) #2

LGTM.

https://codereview.chromium.org/11092101/diff/1/dart/lib/compiler/implementat...
File dart/lib/compiler/implementation/scanner/token.dart (right):

https://codereview.chromium.org/11092101/diff/1/dart/lib/compiler/implementat...
dart/lib/compiler/implementation/scanner/token.dart:143: if (info ==
BAD_INPUT_INFO) {
add comment why this is 1.

Expand Messages | Collapse Messages