Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart

Issue 11092101: Diagnose unbalanced parentheses better. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart b/dart/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart
index 23f7c4bc7cc30e136e7604060c3b61f231f59317..958db2f9fbf7b3a645915da8212a7a9933b0a6d9 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart
@@ -34,6 +34,23 @@ class StringScanner extends ArrayBasedScanner<SourceString> {
tail.next = new StringToken.fromSource(info, value, tokenStart);
tail = tail.next;
}
+
+ void unmatchedBeginGroup(BeginGroupToken begin) {
+ SourceString error = new SourceString('unmatched "${begin.stringValue}"');
+ Token close =
+ new StringToken.fromSource(BAD_INPUT_INFO, error, begin.charOffset);
+ // We want to ensure that unmatched BeginGroupTokens are reported
+ // as errors. However, the rest of the parser assume the groups
+ // are well-balanced and will never look at the endGroup
+ // token. This is a nice property that allows us to skip quickly
+ // over correct code. By inserting an additional error token in
+ // the stream, we can keep ignoring endGroup tokens.
+ Token next =
+ new StringToken.fromSource(BAD_INPUT_INFO, error, begin.charOffset);
+ begin.endGroup = close;
+ close.next = next;
+ next.next = begin.next;
+ }
}
class SubstringWrapper implements SourceString {

Powered by Google App Engine
This is Rietveld 408576698