Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1108903002: Merge to XFA: Reduce usage of operator LPCWSTR from CFX_WideString(). (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
brucedawson
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Reduce usage of operator LPCWSTR from CFX_WideString(). Original Review URL: https://codereview.chromium.org/1101933003 TBR=brucedawson@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4f7bc04ed64edbf72f49b2189f85bb88f0b547c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -204 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +6 lines, -1 line 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_basic.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 3 chunks +6 lines, -11 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_ListBox.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fxedit/fxet_edit.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 9 chunks +13 lines, -15 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 27 chunks +48 lines, -50 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 5 chunks +10 lines, -12 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_IconList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Note.cpp View 6 chunks +9 lines, -10 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Utils.cpp View 4 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR'd.
5 years, 8 months ago (2015-04-27 19:06:24 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 4f7bc04ed64edbf72f49b2189f85bb88f0b547c7 (presubmit successful).
5 years, 8 months ago (2015-04-27 19:07:02 UTC) #2
brucedawson
5 years, 8 months ago (2015-04-27 19:58:49 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698