fpdfsdk/src/javascript/JS_Value.cpp - Issue 1108903002: Merge to XFA: Reduce usage of operator LPCWSTR from CFX_WideString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Value.cpp

Issue 1108903002: Merge to XFA: Reduce usage of operator LPCWSTR from CFX_WideString(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/javascript/JS_Value.cpp

diff --git a/fpdfsdk/src/javascript/JS_Value.cpp b/fpdfsdk/src/javascript/JS_Value.cpp

index be374895e4992814dde9425157e84b9aeb4406ea..1b36f314ca3b06582dba97fda082e6bf352e4a1f 100644

--- a/fpdfsdk/src/javascript/JS_Value.cpp

+++ b/fpdfsdk/src/javascript/JS_Value.cpp

@@ -216,7 +216,7 @@ void CJS_Value::SetNull()

void CJS_Value::operator = (FX_LPCSTR pStr)

{

- operator = (CFX_WideString::FromLocal(pStr));

+ operator = (CFX_WideString::FromLocal(pStr).c_str());

}

void CJS_Value::operator = (CJS_Array & array)

@@ -433,7 +433,7 @@ void CJS_PropValue::operator >>(CFX_WideString &wide_string) const

void CJS_PropValue::operator <<(CFX_WideString wide_string)

{

ASSERT(!m_bIsSetting);

- CJS_Value::operator = (wide_string);

+ CJS_Value::operator = (wide_string.c_str());

}

void CJS_PropValue::operator >>(CJS_Array &array) const

« no previous file with comments | « fpdfsdk/src/javascript/JS_GlobalData.cpp ('k') | fpdfsdk/src/javascript/PublicMethods.cpp » ('j') | no next file with comments »