Merge to XFA: Reduce usage of operator LPCWSTR from CFX_WideString().

fpdfsdk/src/javascript/Field.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
 #include "../../include/javascript/JS_Value.h"
 #include "../../include/javascript/Field.h"
 #include "../../include/javascript/JS_EventHandler.h"
-//#include "../include/JS_ResMgr.h"
 #include "../../include/javascript/JS_Context.h"
 #include "../../include/javascript/JS_Runtime.h"
 #include "../../include/javascript/Document.h"
 #include "../../include/javascript/color.h"
 #include "../../include/javascript/PublicMethods.h"
 #include "../../include/javascript/Icon.h"
 
 
 /* ---------------------- Field ---------------------- */
 
@@ skipping 227 matching lines @@
                 if (nFieldType == FIELDTYPE_COMBOBOX || nFieldType == FIELDTYPE_TEXTFIELD)
                 {
                         for (int i=0,sz=widgets.GetSize(); i<sz; i++)
                         {
                                 CPDFSDK_Widget* pWidget = (CPDFSDK_Widget*)widgets.GetAt(i);
                                 ASSERT(pWidget != NULL);
 
                                 FX_BOOL bFormated = FALSE;
                                 CFX_WideString sValue = pWidget->OnFormat(0, bFormated);
                                 if (bFormated)
-                                        pWidget->ResetAppearance(sValue, FALSE);
+                                        pWidget->ResetAppearance(sValue.c_str(), FALSE);
                                 else
                                         pWidget->ResetAppearance(NULL, FALSE);
                         }
                 }
                 else
                 {
                         for (int i=0,sz=widgets.GetSize(); i<sz; i++)
                         {
                                 CPDFSDK_Widget* pWidget = (CPDFSDK_Widget*)widgets.GetAt(i);
                                 ASSERT(pWidget != NULL);
@@ skipping 36 matching lines @@
         if (pWidget)
         {
                 if (bResetAP)
                 {
                         int nFieldType = pWidget->GetFieldType();
                         if (nFieldType == FIELDTYPE_COMBOBOX || nFieldType == FIELDTYPE_TEXTFIELD)
                         {
                                 FX_BOOL bFormated = FALSE;
                                 CFX_WideString sValue = pWidget->OnFormat(0, bFormated);
                                 if (bFormated)
-                                        pWidget->ResetAppearance(sValue, FALSE);
+                                        pWidget->ResetAppearance(sValue.c_str(), FALSE);
                                 else
                                         pWidget->ResetAppearance(NULL, FALSE);
                         }
                         else
                         {
                                 pWidget->ResetAppearance(NULL, FALSE);
                         }
                 }
 
                 if (bRefresh)
@@ skipping 2790 matching lines @@
                 {
                 case FIELDTYPE_PUSHBUTTON:
                         return FALSE;
                 case FIELDTYPE_COMBOBOX:
                 case FIELDTYPE_TEXTFIELD:
                         {
                                 CFX_WideString swValue = pFormField->GetValue();
 
                                 double dRet;
                                 FX_BOOL bDot;
-                                if (CJS_PublicMethods::ConvertStringToNumber(swValue,dRet,bDot))
+                                if (CJS_PublicMethods::ConvertStringToNumber(swValue.c_str(), dRet, bDot))
                                 {
                                         if (bDot)
                                                 vp << dRet;
                                         else
                                                 vp << dRet;
                                 }
                                 else
                                         vp << swValue;
                         }
                         break;
                 case FIELDTYPE_LISTBOX:
                         {
                                 if (pFormField->CountSelectedItems() > 1)
                                 {
                                         CJS_Array ValueArray(m_isolate);
                                         CJS_Value ElementValue(m_isolate);
                                         int iIndex;
                                         for (int i = 0, sz = pFormField->CountSelectedItems(); i < sz; i++)
                                         {
                                                 iIndex = pFormField->GetSelectedIndex(i);
-                                                ElementValue = pFormField->GetOptionValue(iIndex);
+                                                ElementValue = pFormField->GetOptionValue(iIndex).c_str();
                                                 if (FXSYS_wcslen(ElementValue.ToCFXWideString().c_str()) == 0)
-                                                        ElementValue = pFormField->GetOptionLabel(iIndex);
+                                                        ElementValue = pFormField->GetOptionLabel(iIndex).c_str();
                                                 ValueArray.SetElement(i, ElementValue);
                                         }
                                         vp << ValueArray;
                                 }
                                 else
                                 {
                                         CFX_WideString swValue = pFormField->GetValue();
                                 
                                         double dRet;
                                         FX_BOOL bDot;
-                                        if (CJS_PublicMethods::ConvertStringToNumber(swValue,dRet,bDot))
+                                        if (CJS_PublicMethods::ConvertStringToNumber(swValue.c_str(), dRet, bDot))
                                         {
                                                 if (bDot)
                                                         vp << dRet;
                                                 else
                                                         vp << dRet;
                                         }
                                         else
                                                 vp << swValue;  
                                 }
                         }
                         break;
                 case FIELDTYPE_CHECKBOX:
                 case FIELDTYPE_RADIOBUTTON:
                         {
                                 FX_BOOL bFind = FALSE;
                                 for (int i = 0 , sz = pFormField->CountControls(); i < sz; i++)
                                 {
                                         if (pFormField->GetControl(i)->IsChecked())
                                         {
                                                 CFX_WideString swValue = pFormField->GetControl(i)->GetExportValue();
-                                                
                                                 double dRet;
                                                 FX_BOOL bDot;
-                                                if (CJS_PublicMethods::ConvertStringToNumber(swValue,dRet,bDot))
+                                                if (CJS_PublicMethods::ConvertStringToNumber(swValue.c_str(), dRet, bDot))
                                                 {
                                                         if (bDot)
                                                                 vp << dRet;
                                                         else
                                                                 vp << dRet;
                                                 }
                                                 else
                                                         vp << swValue;
 
                                                 bFind = TRUE;
@@ skipping 185 matching lines @@
         CPDF_FormField* pFormField = (CPDF_FormField*)FieldArray.ElementAt(0);
         ASSERT(pFormField != NULL);
         
         if (pFormField->GetFieldType() != FIELDTYPE_PUSHBUTTON)
                 return FALSE;
 
         CPDF_FormControl* pFormControl = GetSmartFieldControl(pFormField);
         if (!pFormControl)return FALSE;
         
         if (nface == 0)
-                vRet = pFormControl->GetNormalCaption();
+                vRet = pFormControl->GetNormalCaption().c_str();
         else if (nface == 1)
-                vRet = pFormControl->GetDownCaption();
+                vRet = pFormControl->GetDownCaption().c_str();
         else if (nface == 2)
-                vRet = pFormControl->GetRolloverCaption();
+                vRet = pFormControl->GetRolloverCaption().c_str();
         else
                 return FALSE;
 
         return TRUE;
 }
 
 //#pragma warning(disable: 4800)
 
 FX_BOOL Field::buttonGetIcon(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
@@ skipping 269 matching lines @@
 
         if ((pFormField->GetFieldType() == FIELDTYPE_LISTBOX)
                 || (pFormField->GetFieldType() == FIELDTYPE_COMBOBOX))
         {
                 if (nIdx == -1 || nIdx > pFormField->CountOptions())
                         nIdx = pFormField->CountOptions() -1;
                 if (bExport)
                 {
                         CFX_WideString strval = pFormField->GetOptionValue(nIdx);
                         if (strval.IsEmpty())
-                                vRet = pFormField->GetOptionLabel(nIdx);
+                                vRet = pFormField->GetOptionLabel(nIdx).c_str();
                         else
-                                vRet = strval;
+                                vRet = strval.c_str();
                 }
                 else
-                        vRet = pFormField->GetOptionLabel(nIdx);
+                        vRet = pFormField->GetOptionLabel(nIdx).c_str();
         }
         else
                 return FALSE;
 
         return TRUE;
 }
 
 FX_BOOL Field::getLock(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         return FALSE;
@@ skipping 404 matching lines @@
 
 #define JS_FIELD_MINWIDTH       1
 #define JS_FIELD_MINHEIGHT      1
 
 void Field::AddField(CPDFSDK_Document* pDocument, int nPageIndex, int nFieldType,
                                                         const CFX_WideString& sName, const CPDF_Rect& rcCoords)
 {
         //Not supported.
 }