Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 1108773003: Revert of cc: Remove tile sharing from tilings. (Closed)

Created:
5 years, 8 months ago by vmpstr
Modified:
5 years, 8 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Remove tile sharing from tilings. (patchset #20 id:380001 of https://codereview.chromium.org/1051993002/) Reason for revert: Several failures happened as a result. Original issue's description: > cc: Remove tile sharing from tilings. > > This patch removes sharing tiles from tilings. Previously, tiles > that were not invalidated were shared between the pending and > the active trees. With this patch, tiles that are exist on the > active tree and are not invalidated are not created on the pending > tree, resulting in fewer overall tiles. This improves performance > of updating and managing tiles. > > Also, this patch opens up opportunities for a lot of code clean > up that can otherwise be confusing when two trees are involved. > > R=danakj, enne > > Committed: https://crrev.com/0061b75e810f088900a0a8fbdd29ba5595c73016 > Cr-Commit-Position: refs/heads/master@{#326804} TBR=enne@chromium.org,danakj@chromium.org,timford35@gmail.com BUG=481421, 481509, 481480 Committed: https://crrev.com/3bc40f2782615107e6a8f41b056a6477275f75a8 Cr-Commit-Position: refs/heads/master@{#327093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1135 lines, -1258 lines) Patch
M cc/base/tiling_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/base/tiling_data.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 58 chunks +304 lines, -243 lines 0 comments Download
M cc/resources/eviction_tile_priority_queue.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 8 chunks +54 lines, -59 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 11 chunks +291 lines, -244 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 4 chunks +3 lines, -9 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 20 chunks +72 lines, -78 lines 0 comments Download
M cc/resources/raster_tile_priority_queue_all.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/resources/raster_tile_priority_queue_all.cc View 8 chunks +86 lines, -24 lines 0 comments Download
M cc/resources/raster_tile_priority_queue_required.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/resources/raster_tile_priority_queue_required.cc View 1 chunk +9 lines, -33 lines 0 comments Download
M cc/resources/tile.h View 4 chunks +41 lines, -7 lines 0 comments Download
M cc/resources/tile.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M cc/resources/tile_manager.cc View 4 chunks +5 lines, -14 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 21 chunks +65 lines, -76 lines 0 comments Download
M cc/resources/tiling_set_eviction_queue.h View 5 chunks +1 line, -27 lines 0 comments Download
M cc/resources/tiling_set_eviction_queue.cc View 16 chunks +105 lines, -194 lines 0 comments Download
M cc/resources/tiling_set_raster_queue_all.h View 9 chunks +4 lines, -35 lines 0 comments Download
M cc/resources/tiling_set_raster_queue_all.cc View 16 chunks +37 lines, -145 lines 0 comments Download
M cc/resources/tiling_set_raster_queue_required.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/tiling_set_raster_queue_required.cc View 2 chunks +20 lines, -32 lines 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_picture.cc View 4 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vmpstr
Created Revert of cc: Remove tile sharing from tilings.
5 years, 8 months ago (2015-04-27 17:03:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108773003/1
5 years, 8 months ago (2015-04-27 17:05:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 19:04:45 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 19:06:30 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bc40f2782615107e6a8f41b056a6477275f75a8
Cr-Commit-Position: refs/heads/master@{#327093}

Powered by Google App Engine
This is Rietveld 408576698