Making ShowExtensionInstallDialog a callback

chrome/browser/extensions/extension_install_dialog.cc

Index: chrome/browser/extensions/extension_install_dialog.cc
diff --git a/chrome/browser/extensions/extension_install_dialog.cc b/chrome/browser/extensions/extension_install_dialog.cc
index a3cd87bf911ec99916e8988d0b5bd51e1665fcee..84068312753b98104fe3e1634c77d707a3a624f4 100644
--- a/chrome/browser/extensions/extension_install_dialog.cc
+++ b/chrome/browser/extensions/extension_install_dialog.cc
@@ -59,10 +59,17 @@ AutoConfirmForTest CheckAutoConfirmCommandLineSwitch() {
 
 }  // namespace
 
-void ShowExtensionInstallDialog(gfx::NativeWindow parent,
-                                content::PageNavigator* navigator,
-                                ExtensionInstallPrompt::Delegate* delegate,
-                                const ExtensionInstallPrompt::Prompt& prompt) {
+ExtensionInstallDialog::ExtensionInstallDialog() {
+}
+
+ExtensionInstallDialog::~ExtensionInstallDialog() {
+}
+
+void ExtensionInstallDialog::ShowExtensionInstallDialog(
+    gfx::NativeWindow parent,
+    content::PageNavigator* navigator,
+    ExtensionInstallPrompt::Delegate* delegate,
+    const ExtensionInstallPrompt::Prompt& prompt) {
   AutoConfirmForTest auto_confirm = CheckAutoConfirmCommandLineSwitch();

[Aaron Boodman, 2012/10/11 01:57:57]

Is it possible to move this code into ExtensionInstallPrompt? If so, this would
just be a pure interface, not a base class, which would be nice.

[sail, 2012/10/11 02:32:16]

Done.

   if (auto_confirm != DO_NOT_SKIP) {
     DoAutoConfirm(auto_confirm, delegate);