chrome/browser/extensions/api/webstore_private/webstore_private_api.cc - Issue 11087071: Making ShowExtensionInstallDialog a callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 11087071: Making ShowExtensionInstallDialog a callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

index 9959e34c19341ec63d0c451767af5b9a71cf9d56..50ebf38cd667f37ed25cdfe02f106bfd1bdc833f 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

@@ -325,7 +325,11 @@ void BeginInstallWithManifestFunction::OnWebstoreParseSuccess(

install_prompt_.reset(

chrome::CreateExtensionInstallPromptWithBrowser(GetCurrentBrowser()));

- install_prompt_->ConfirmWebstoreInstall(this, dummy_extension_, &icon_);

+ install_prompt_->ConfirmWebstoreInstall(

+ this,

+ dummy_extension_,

+ &icon_,

+ ExtensionInstallDialog::CreateDefaultImpl());

Aaron Boodman 2012/10/11 01:57:57 Can you make it so you can just pass NULL here and

sail 2012/10/11 02:32:16 Done.

// Control flow finishes up in InstallUIProceed or InstallUIAbort.

}

« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.h » ('j') | chrome/browser/extensions/extension_install_dialog.cc » ('J')