Making ShowExtensionInstallDialog a callback

chrome/browser/extensions/extension_install_dialog.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_dialog.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 41 matching lines @@
     return PROCEED;
   else if (value == "cancel")
     return ABORT;
   else
     NOTREACHED();
   return DO_NOT_SKIP;
 }
 
 }  // namespace
 
-void ShowExtensionInstallDialog(gfx::NativeWindow parent,
-                                content::PageNavigator* navigator,
-                                ExtensionInstallPrompt::Delegate* delegate,
-                                const ExtensionInstallPrompt::Prompt& prompt) {
+ExtensionInstallDialog::ExtensionInstallDialog() {
+}
+
+ExtensionInstallDialog::~ExtensionInstallDialog() {
+}
+
+void ExtensionInstallDialog::ShowExtensionInstallDialog(
+    gfx::NativeWindow parent,
+    content::PageNavigator* navigator,
+    ExtensionInstallPrompt::Delegate* delegate,
+    const ExtensionInstallPrompt::Prompt& prompt) {
   AutoConfirmForTest auto_confirm = CheckAutoConfirmCommandLineSwitch();

[Aaron Boodman, 2012/10/11 01:57:57]

Is it possible to move this code into ExtensionInstallPrompt? If so, this would
just be a pure interface, not a base class, which would be nice.

[sail, 2012/10/11 02:32:16]

Done.

   if (auto_confirm != DO_NOT_SKIP) {
     DoAutoConfirm(auto_confirm, delegate);
     return;
   }
   ShowExtensionInstallDialogImpl(parent, navigator, delegate, prompt);
 }