Making ShowExtensionInstallDialog a callback

chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/webstore_private/webstore_private_api.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 307 matching lines @@
       &error);
 
   if (!dummy_extension_) {
     OnWebstoreParseFailure(id_, WebstoreInstallHelper::Delegate::MANIFEST_ERROR,
                            kInvalidManifestError);
     return;
   }
 
   install_prompt_.reset(
       chrome::CreateExtensionInstallPromptWithBrowser(GetCurrentBrowser()));
-  install_prompt_->ConfirmWebstoreInstall(this, dummy_extension_, &icon_);
+  install_prompt_->ConfirmWebstoreInstall(
+      this,
+      dummy_extension_,
+      &icon_,
+      ExtensionInstallDialog::CreateDefaultImpl());

[Aaron Boodman, 2012/10/11 01:57:57]

Can you make it so you can just pass NULL here and it will default to
CreateDefaultImpl()?

[sail, 2012/10/11 02:32:16]

Done.

   // Control flow finishes up in InstallUIProceed or InstallUIAbort.
 }
 
 void BeginInstallWithManifestFunction::OnWebstoreParseFailure(
     const std::string& id,
     WebstoreInstallHelper::Delegate::InstallHelperResultCode result_code,
     const std::string& error_message) {
   CHECK_EQ(id_, id);
 
   // Map from WebstoreInstallHelper's result codes to ours.
@@ skipping 166 matching lines @@
   feature_checker_->CheckGPUFeatureAvailability();
   return true;
 }
 
 void GetWebGLStatusFunction::OnFeatureCheck(bool feature_allowed) {
   CreateResult(feature_allowed);
   SendResponse(true);
 }
 
 }  // namespace extensions